From e902c22970088f28094149588867fa029ed491a3 Mon Sep 17 00:00:00 2001
From: peptiderepo <bot@peptiderepo.com>
Date: Wed, 17 Jun 2026 06:02:12 +0000
Subject: [PATCH] fix(smoke): use regex to avoid false-positive on placeholder
 in key assertion
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The write-only security check in 08-pr-vision-admin.spec.ts asserted
page.content() does not contain 'sk-or-'. The password input for the
API key renders with placeholder="sk-or-…" (an ellipsis format hint
shown when the key is admin-managed). This placeholder contains the
literal string 'sk-or-' so the naive toContain assertion trips even
though value="" and no real key is in the page.

Fix: replace toContain('sk-or-') with toMatch(/sk-or-v1-[A-Za-z0-9]{20,}/).
A real OpenRouter key uses the format 'sk-or-v1-<20+ alnum chars>';
the placeholder ellipsis 'sk-or-…' never matches this pattern, so the
false-positive is eliminated. The assertion still catches any real key
accidentally rendered in server-side HTML.

The value="" assertion is unchanged and continues to guard the core
write-only invariant independently.

Agent-Session: fix-smoke-key-assertion-20260617
---
 tests/08-pr-vision-admin.spec.ts | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/tests/08-pr-vision-admin.spec.ts b/tests/08-pr-vision-admin.spec.ts
index 223bcb8..6e95f68 100644
--- a/tests/08-pr-vision-admin.spec.ts
+++ b/tests/08-pr-vision-admin.spec.ts
@@ -34,7 +34,11 @@
  *   The stored OpenRouter key must NEVER appear in page source.
  *   #prv_api_key renders with value="" on every page load regardless of
  *   whether a key is stored. This spec asserts the empty value and asserts
- *   that known API key prefixes ("sk-or-") are absent from the full body.
+ *   that no structurally valid key token (regex /sk-or-v1-[A-Za-z0-9]{20,}/)
+ *   appears in the full body HTML. A regex is used instead of a naive
+ *   toContain('sk-or-') to avoid a false-positive on the password input's
+ *   placeholder="sk-or-…" attribute (the ellipsis is a format hint, not a
+ *   token body, and won't match the regex).
  *
  * @see peptiderepo/pr-vision includes/core/class-prv-admin-page.php
  * @see peptiderepo/pr-vision includes/core/class-prv-settings-page.php
@@ -170,10 +174,18 @@ test.describe('WP Admin - PR Vision Settings page (API-key-manager)', () => {
     const inputValue = await keyInput.getAttribute('value');
     expect(inputValue ?? '').toBe('');
 
-    // Security check: known OpenRouter key prefixes must not appear anywhere in
-    // the page HTML -- guards against accidental server-side leakage.
+    // Security check: a *real* OpenRouter key (format "sk-or-v1-<20+ alnum chars>")
+    // must not appear anywhere in the page HTML -- guards against accidental
+    // server-side leakage.
+    //
+    // NOTE: We use a regex rather than the naive toContain('sk-or-') to avoid
+    // a false-positive: the password input carries placeholder="sk-or-…"
+    // (an ellipsis format-hint, not a token body) which contains the literal
+    // string "sk-or-" but is NOT a leaked key.  A regex that requires the
+    // "v1-" segment and at least 20 alphanumeric characters only matches a
+    // structurally valid key, so the placeholder never trips it.
     const html = await page.content();
-    expect(html).not.toContain('sk-or-');
+    expect(html).not.toMatch(/sk-or-v1-[A-Za-z0-9]{20,}/);
   });
 });