ci(deploy): promote smoke to a production gate

deploy-production now needs smoke; a smoke FAILURE blocks prod while a skipped
smoke (run_smoke:false) still allows it. Automated functional gate replacing
the removed human approval gate — hands-off but safe.

Agent-Session: cto gate-smoke

.github/workflows/deploy-app.yml

@@ -79,7 +79,10 @@ jobs:
 
   deploy-production:
     name: Deploy to Production
-    needs: [deploy-staging]
+    # Smoke is now a GATE: a smoke FAILURE blocks production. A deliberately
+    # skipped smoke (run_smoke: false) still allows prod via the if-condition.
+    needs: [deploy-staging, smoke]
+    if: ${{ !cancelled() && needs.deploy-staging.result == 'success' && needs.smoke.result != 'failure' }}
     runs-on: ubuntu-latest
     environment: production
     steps:

tests/03-admin-plugins.spec.ts

@@ -100,8 +100,8 @@ test.describe('WP Admin — Peptide Repo Core admin', () => {
     // PR Core registers the peptide CPT which creates a "Peptides" menu item
     const nav = page.locator('#adminmenu');
     await expect(nav).toBeVisible();
-    // "Peptides" top-level menu item is registered by the peptide CPT
+    // PR Core registers the peptide CPT, which adds a post_type=peptide admin menu/submenu (label-agnostic).
-    await expect(nav.locator('text=Peptides')).toBeVisible({ timeout: 10_000 });
+    await expect(nav.locator('a[href*="post_type=peptide"]').first()).toBeAttached({ timeout: 10_000 });
   });
 
   test('PR Core Settings page loads', async ({ page }) => {