peptide-repo/peptide-e2e
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ci): drop --with-deps from playwright install on self-hosted runner (v1.7.2) #23

Merged
peptiderepo merged 3 commits from claude/smoke-playwright-nodeps-20260617 into main 2026-06-17 04:51:33 +00:00
Conversation 0 Commits 3 Files Changed 3 +10 -3
peptiderepo commented 2026-06-17 04:50:33 +00:00 (Migrated from github.com)
Copy Link

What changed

Drop --with-deps from npx playwright install chromium in .github/workflows/smoke.yml.

Why

The peptide-vps self-hosted runner has Playwright OS deps pre-installed system-wide by root during runner setup. The --with-deps flag invokes sudo apt-get, which is blocked by the runner's NoNewPrivileges=true systemd hardening (ghrunner has no sudo). This caused the smoke job to fail on every repo using the shared pipeline.

SSH verification

Confirmed via su - ghrunner: npx playwright install chromium (no --with-deps) succeeds without sudo and downloads Chromium 149.0.7827.55 to /home/ghrunner/.cache/ms-playwright/. No OS libs were missing.

Risk flags

Minimal. Single-line change. Only removes an unnecessary flag; all browser functionality unchanged. NoNewPrivileges hardening is preserved.

Test plan

  • CI on this PR: ci-self-test.yml validates the workflow itself
  • After merge: re-run peptide-reconstitution-calculator Deploy workflow; smoke job should go green on peptide-vps

Bump: v1.7.1 → v1.7.2

Agent-Session: smoke-playwright-nodeps-20260617

## What changed Drop `--with-deps` from `npx playwright install chromium` in `.github/workflows/smoke.yml`. ## Why The `peptide-vps` self-hosted runner has Playwright OS deps pre-installed system-wide by root during runner setup. The `--with-deps` flag invokes `sudo apt-get`, which is blocked by the runner's `NoNewPrivileges=true` systemd hardening (ghrunner has no sudo). This caused the `smoke` job to fail on every repo using the shared pipeline. ## SSH verification Confirmed via `su - ghrunner`: `npx playwright install chromium` (no `--with-deps`) succeeds without sudo and downloads Chromium 149.0.7827.55 to `/home/ghrunner/.cache/ms-playwright/`. No OS libs were missing. ## Risk flags Minimal. Single-line change. Only removes an unnecessary flag; all browser functionality unchanged. NoNewPrivileges hardening is preserved. ## Test plan - CI on this PR: `ci-self-test.yml` validates the workflow itself - After merge: re-run peptide-reconstitution-calculator Deploy workflow; `smoke` job should go green on `peptide-vps` Bump: v1.7.1 → v1.7.2 Agent-Session: smoke-playwright-nodeps-20260617
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 deploy-health
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: peptide-repo/peptide-e2e#23
Delete Branch "claude/smoke-playwright-nodeps-20260617"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?