Files

peptiderepo 5c483fdc34 fix: PHP 8.3 TypeError in dashboard top-articles SUM casts + CHANGELOG (#32 )

- admin/partials/dashboard.php lines 108-109: cast $article->total_clicks
  and $article->total_unique to (int) before number_format(). Both are
  SUM() aggregate columns from $wpdb->get_results() returned as strings;
  same PHP 8.3 TypeError vector as the articles-list fix.
- tests/unit/DashboardTopArticlesCastTest.php: two unit tests mirroring
  the ArticlesListTotalCastTest pattern (numeric string + null cases).
- CHANGELOG [2.5.1]: fix (# 31) typo -> (#32); add dashboard fix entry.
- $topic['total_clicks'] at line 137 is safe (already cast to int in
  Peptide_News_Analytics_Reports::get_popular_topics() at assignment).
- $total_clicks/$total_unique at lines 48/52 are safe (array_sum coerces).

Agent-Session: engineer-infra-dashboard-cast-fix-20260617

2026-06-17 06:09:49 +00:00

1.9 KiB

Raw Permalink Blame History

Changelog

All notable changes to Peptide News Plugin are documented here. Format: Keep a Changelog. Versioning: Semantic Versioning.

[2.5.1] - 2026-06-17

Fixed

PHP 8.3 TypeError on Articles admin page: number_format() rejects the numeric string returned by $wpdb->get_var(). Cast $total to (int) at point of assignment in admin/partials/articles-list.php (#32).
PHP 8.3 TypeError on Analytics Dashboard page: number_format() rejects SUM aggregate strings returned by $wpdb->get_results(). Cast $article->total_clicks and $article->total_unique to (int) inline in admin/partials/dashboard.php (same-class fix, no PR number — follow-on to #32).

[2.5.0] — 2026-06-16

Changed

CI standardization (estate wave 2): Replace per-repo CI jobs in ci.yml with a thin caller of peptiderepo/peptide-e2e/.github/workflows/ci.yml@main (tests: stubs, has_js: true). Adds workflow_call trigger so deploy.yml gate remains valid.
Extract security-audit job from ci.yml into standalone .github/workflows/security-audit.yml (kept as-is, unique to this repo).
deploy.yml: elevate permissions to contents: write so the nested phpcbf commit-back step in the reusable workflow receives the correct token scope.
composer.json: pin test script to vendor/bin/phpunit --configuration phpunit.xml.dist for explicit path resolution in CI; pin lint / lint:fix to vendor/bin/.
phpunit.xml.dist: add XSD reference for PHPUnit 9.6; drop deprecated convertErrorsToExceptions, convertNoticesToExceptions, convertWarningsToExceptions attributes.

Notes

rollback.yml and cto-review.yml and main-push-audit.yml unchanged — unique / estate-separate.
No functional code changes in this commit.

Prior history

Versions prior to 2.5.0 were not tracked in a CHANGELOG. See git log for details.

1.9 KiB Raw Permalink Blame History