Adopt reusable CI standard + PHPUnit suite (#8)
* feat(ci): adopt estate CI + add PHPUnit suite from scratch (v1.2.0) - Add PHPUnit 9.6 test suite (WP stubs, tests: stubs) — 40 tests across 4 files: MathTest: 25 tests covering all PRC_Math public methods and calculate() orchestrator with real peptide scenarios (BPC-157/TB-500/Semaglutide/MK-677/ Ipamorelin) plus edge cases (zero water, negative inputs, floor rounding, rounding precision, mcg↔mg conversion). DefaultPresetsTest: 11 tests — all 8 expected slugs, required keys per preset (dataProvider), dose_unit validity, min<max range, source field, spot-checks. RestControllerTest: 7 tests — calculate() 200 + correct values (mcg+mg), get_presets() 200, get_preset() 200 for known slug / WP_Error for unknown. PresetProviderTest: 4 tests — fallback to defaults sans PR Core, slug key present, cache invalidation, idempotent invalidation. - Add phpunit.xml.dist + tests/bootstrap.php (WP function/class stubs). - Add composer test script: vendor/bin/phpunit --configuration phpunit.xml.dist. - Add phpunit/phpunit ^9.6 + yoast/phpunit-polyfills ^2.0 to require-dev. - Replace standalone ci.yml with thin caller to estate reusable workflow: uses: peptiderepo/peptide-e2e/.github/workflows/ci.yml@main with: tests: stubs, has_js: true permissions: contents: write (required for phpcbf commit-back) workflow_call (required for deploy.yml gate). - deploy.yml unchanged — already gates on ./ci.yml + uses shared deploy-app.yml. - Version bump 1.1.0 → 1.2.0. Agent-Session: claude/adopt-ci-20260616 * style: auto-fix PHPCS violations via phpcbf * fix(ci): resolve latent PHPCS + JS lint failures Latent debt surfaced by the reusable PHPCS job (previously continue-on-error). PHPCS fixes (all pre-existing, not introduced by this PR): - Add @package PeptideReconstitutionCalculator to file docblocks in all 12 PHP files (previously missing; phpcbf cannot insert missing docblock tags). - Replace two short-ternary ?: operators in class-prc-preset-provider.php with full ternary (Universal.Operators.DisallowShortTernary.Found; lines 136+152). JS lint fix: - Add package.json + package-lock.json (no deps; lint script = node --check) so the reusable lint-js job's npm ci / cache: npm steps succeed. The calculator ships vanilla JS with no build toolchain — package.json is the minimal stub the reusable workflow requires for has_js: true. Agent-Session: claude/adopt-ci-20260616 * style: auto-fix PHPCS violations via phpcbf * fix(phpcs): suppress intentional warnings with phpcs:ignore annotations uninstall.php: direct wpdb->query() intentional in uninstall (no caching available); add phpcs:ignore DirectDatabaseQuery.DirectQuery and NoCaching. class-prc-rest-controller.php get_presets(): request param required by WP REST API callback contract; add phpcs:ignore UnusedFunctionParameter. Agent-Session: claude/adopt-ci-20260616 --------- Co-authored-by: peptiderepo <bot@peptiderepo.com> Co-authored-by: peptiderepo <peptiderepo@users.noreply.github.com>
This commit is contained in:
@@ -9,6 +9,7 @@
|
||||
* @see class-prc-preset-provider.php — Data source for presets.
|
||||
* @see class-prc-math.php — Calculation engine.
|
||||
* @see class-prc-shortcode.php — Frontend JS consumes these endpoints.
|
||||
* @package PeptideReconstitutionCalculator
|
||||
*/
|
||||
|
||||
declare(strict_types=1);
|
||||
@@ -38,39 +39,39 @@ class PRC_Rest_Controller {
|
||||
register_rest_route(
|
||||
self::NAMESPACE,
|
||||
'/presets',
|
||||
[
|
||||
array(
|
||||
'methods' => 'GET',
|
||||
'callback' => [ $this, 'get_presets' ],
|
||||
'callback' => array( $this, 'get_presets' ),
|
||||
'permission_callback' => '__return_true',
|
||||
]
|
||||
)
|
||||
);
|
||||
|
||||
register_rest_route(
|
||||
self::NAMESPACE,
|
||||
'/presets/(?P<slug>[a-z0-9-]+)',
|
||||
[
|
||||
array(
|
||||
'methods' => 'GET',
|
||||
'callback' => [ $this, 'get_preset' ],
|
||||
'callback' => array( $this, 'get_preset' ),
|
||||
'permission_callback' => '__return_true',
|
||||
'args' => [
|
||||
'slug' => [
|
||||
'args' => array(
|
||||
'slug' => array(
|
||||
'type' => 'string',
|
||||
'sanitize_callback' => 'sanitize_title',
|
||||
'required' => true,
|
||||
],
|
||||
],
|
||||
]
|
||||
),
|
||||
),
|
||||
)
|
||||
);
|
||||
|
||||
register_rest_route(
|
||||
self::NAMESPACE,
|
||||
'/calculate',
|
||||
[
|
||||
array(
|
||||
'methods' => 'POST',
|
||||
'callback' => [ $this, 'calculate' ],
|
||||
'callback' => array( $this, 'calculate' ),
|
||||
'permission_callback' => '__return_true',
|
||||
'args' => $this->get_calculate_args(),
|
||||
]
|
||||
)
|
||||
);
|
||||
}
|
||||
|
||||
@@ -80,7 +81,7 @@ class PRC_Rest_Controller {
|
||||
* @param \WP_REST_Request $request Request object.
|
||||
* @return \WP_REST_Response
|
||||
*/
|
||||
public function get_presets( \WP_REST_Request $request ): \WP_REST_Response {
|
||||
public function get_presets( \WP_REST_Request $request ): \WP_REST_Response { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.Found
|
||||
$provider = new PRC_Preset_Provider();
|
||||
$presets = $provider->get_all_presets();
|
||||
|
||||
@@ -107,7 +108,7 @@ class PRC_Rest_Controller {
|
||||
return new \WP_Error(
|
||||
'prc_preset_not_found',
|
||||
__( 'Preset not found.', 'peptide-reconstitution-calculator' ),
|
||||
[ 'status' => 404 ]
|
||||
array( 'status' => 404 )
|
||||
);
|
||||
}
|
||||
|
||||
@@ -137,31 +138,31 @@ class PRC_Rest_Controller {
|
||||
* @return array<string, array<string, mixed>>
|
||||
*/
|
||||
private function get_calculate_args(): array {
|
||||
return [
|
||||
'vial_mg' => [
|
||||
return array(
|
||||
'vial_mg' => array(
|
||||
'type' => 'number',
|
||||
'required' => true,
|
||||
'sanitize_callback' => 'floatval',
|
||||
'validate_callback' => fn( $v ) => is_numeric( $v ) && (float) $v > 0,
|
||||
],
|
||||
'water_ml' => [
|
||||
),
|
||||
'water_ml' => array(
|
||||
'type' => 'number',
|
||||
'required' => true,
|
||||
'sanitize_callback' => 'floatval',
|
||||
'validate_callback' => fn( $v ) => is_numeric( $v ) && (float) $v > 0,
|
||||
],
|
||||
'desired_dose' => [
|
||||
),
|
||||
'desired_dose' => array(
|
||||
'type' => 'number',
|
||||
'required' => true,
|
||||
'sanitize_callback' => 'floatval',
|
||||
'validate_callback' => fn( $v ) => is_numeric( $v ) && (float) $v > 0,
|
||||
],
|
||||
'dose_unit' => [
|
||||
),
|
||||
'dose_unit' => array(
|
||||
'type' => 'string',
|
||||
'required' => true,
|
||||
'sanitize_callback' => 'sanitize_text_field',
|
||||
'validate_callback' => fn( $v ) => in_array( $v, [ 'mcg', 'mg' ], true ),
|
||||
],
|
||||
];
|
||||
'validate_callback' => fn( $v ) => in_array( $v, array( 'mcg', 'mg' ), true ),
|
||||
),
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user