peptide-repo/peptide-repo-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(jsonld): accept string|array @type — v0.6.1

Browse Source 
Yoast's wpseo_schema_webpage_type filter passes ['WebPage'] (array) on
every singular page. The v0.6.0 retype_to_medical_webpage() signature
was strict string, causing TypeError → HTTP 500 on ALL singulars under
strict_types=1. Secondary bug: enrich_webpage_piece compared
'WebPage' === $piece['@type'] but @type is an array, so MedicalWebPage
enrichment never injected.

Fix:
- retype_to_medical_webpage: string|array param + return (PHP 8.1+ union)
- enrich_webpage_piece: normalise @type to array before in_array() check
- Add tests/unit/test-jsonld-webpage.php: regression tests with array
  input for both code paths; fail against v0.6.0, pass after fix
- Bump version header + PR_CORE_VERSION constant to 0.6.1
- CHANGELOG entry under [0.6.1]

Agent-Session: jsonld-webpage-typefix v0.6.1
This commit is contained in:
peptiderepo
2026-06-13 06:44:00 +00:00
parent e9d97b51e2
commit 077c4b0e51
4 changed files with 192 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
includes/frontend/class-pr-core-jsonld-webpage.php
View File

@@ -28,10 +28,17 @@ class PR_Core_Jsonld_Webpage {
* Hooked on: wpseo_schema_webpage_type (Yoast SEO ≥ 19.x).
* Passes through unchanged on non-peptide pages.
*
* @param string $type Existing Yoast page type (e.g., 'WebPage').
* @return string 'MedicalWebPage' on peptide singles, $type otherwise.
* Yoast contract: passes a plain string (e.g., 'CollectionPage') for
* non-singular special types, but an ARRAY (e.g., ['WebPage']) for every
* singular page — including plain Pages and monographs. Under strict_types=1
* a string-only signature throws TypeError on all singulars. This method
* therefore accepts string|array and returns the same union type so callers
* (Yoast's filter chain) receive the value in the shape they passed it.
*
* @param string|array $type Existing Yoast page type — string or string[].
* @return string|array 'MedicalWebPage' (string) on peptide singles; $type unchanged otherwise.
*/
public function retype_to_medical_webpage( string $type ): string {
public function retype_to_medical_webpage( string|array $type ): string|array {
if ( is_singular( PR_Core_Peptide_CPT::POST_TYPE ) ) {
return 'MedicalWebPage';
}
@@ -55,8 +62,8 @@ class PR_Core_Jsonld_Webpage {
return $graph;
}
$post_id = get_the_ID();
$enrichments = $this->build_webpage_enrichments( (int) $post_id );
$post_id = get_the_ID();
$enrichments = $this->build_webpage_enrichments( (int) $post_id );
if ( empty( $enrichments ) ) {
return $graph;
@@ -67,8 +74,12 @@ class PR_Core_Jsonld_Webpage {
continue;
}
$type = $piece['@type'] ?? '';
if ( 'WebPage' === $type || 'MedicalWebPage' === $type ) {
// Yoast may set @type as a plain string OR an array of strings.
// Normalise to array so in_array() works regardless of shape.
$raw_type = $piece['@type'] ?? '';
$types = is_array( $raw_type ) ? $raw_type : [ $raw_type ];
if ( in_array( 'WebPage', $types, true ) || in_array( 'MedicalWebPage', $types, true ) ) {
foreach ( $enrichments as $key => $value ) {
$piece[ $key ] = $value;
}