ci: fix deploy gate — smoke is informational, not a prod blocker
- Remove invalid continue-on-error from reusable workflow call (GitHub Actions doesn't support this property on 'uses:' jobs; it caused 0-job workflow failures) - Remove 'smoke' from deploy-production needs — smoke failures (e.g. Playwright infra issues) must not block valid production deploys. This matches the pattern already used by the theme repo. - Smoke still runs and uploads artifacts; it's just not a gate.
This commit is contained in:
3
.github/workflows/deploy.yml
vendored
3
.github/workflows/deploy.yml
vendored
@@ -51,7 +51,6 @@ jobs:
|
|||||||
smoke:
|
smoke:
|
||||||
name: Smoke tests (staging)
|
name: Smoke tests (staging)
|
||||||
needs: deploy-staging
|
needs: deploy-staging
|
||||||
continue-on-error: true
|
|
||||||
uses: peptiderepo/peptide-e2e/.github/workflows/smoke.yml@main
|
uses: peptiderepo/peptide-e2e/.github/workflows/smoke.yml@main
|
||||||
secrets:
|
secrets:
|
||||||
STAGING_WP_ADMIN_USER: ${{ secrets.STAGING_WP_ADMIN_USER }}
|
STAGING_WP_ADMIN_USER: ${{ secrets.STAGING_WP_ADMIN_USER }}
|
||||||
@@ -59,7 +58,7 @@ jobs:
|
|||||||
|
|
||||||
deploy-production:
|
deploy-production:
|
||||||
name: Deploy to Production
|
name: Deploy to Production
|
||||||
needs: [ci, deploy-staging, smoke]
|
needs: [ci, deploy-staging] # smoke is informational; not gating prod
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
environment: production
|
environment: production
|
||||||
steps:
|
steps:
|
||||||
|
|||||||
Reference in New Issue
Block a user