d69f637b06
CI on 61cf00c failed PHPUnit with "Call to undefined function
plugin_dir_path()" — the test required peptide-search-ai.php, which calls
plugin_dir_path() at top level (line 19) before any hook. Stubbing every
top-level WP function the plugin file touches was the wrong shape of fix.
Proper fix: move the upgrade logic into includes/class-psa-upgrade.php so
the test can require just the helper class, matching the pattern every
other includes/ module follows.
- New: includes/class-psa-upgrade.php with PSA_Upgrade::is_needed()
(pure) and PSA_Upgrade::maybe_run() (driver). OPTION_NAME and
DEFAULT_STORED_VERSION exposed as constants.
- peptide-search-ai.php: psa_admin_init() now calls PSA_Upgrade::maybe_run();
the inline helper functions and docblocks are removed.
- tests/bootstrap.php: loads class-psa-upgrade.php alongside the other
tested classes.
- tests/unit/UpgradeTest.php: rewritten against PSA_Upgrade; adds two
extra assertions on the constants for stability.
- ARCHITECTURE.md: refreshed to reference the class and its constants.
No behavioral change. The cost-tracker schema upgrade still runs once per
admin_init when PSA_VERSION advances past psa_db_version.
Agent-Session: cowork-qa-p1-fixes-20260414
82 lines
2.6 KiB
PHP
82 lines
2.6 KiB
PHP
<?php
|
|
/**
|
|
* Schema upgrade helpers for Peptide Search AI.
|
|
*
|
|
* What: Pure-function helpers that decide whether a database schema upgrade
|
|
* is required, plus the driver that runs the upgrade when the installed
|
|
* code version is newer than the stored psa_db_version option.
|
|
*
|
|
* Who triggers it: psa_admin_init() in peptide-search-ai.php calls
|
|
* PSA_Upgrade::maybe_run() on every WordPress admin_init hook.
|
|
*
|
|
* Dependencies: PSA_Cost_Tracker (for re-running dbDelta on the
|
|
* cost-tracker table), WordPress options API (get_option / update_option),
|
|
* and the PSA_VERSION constant defined in peptide-search-ai.php.
|
|
*
|
|
* @package PeptideSearchAI
|
|
*/
|
|
|
|
if ( ! defined( 'ABSPATH' ) ) {
|
|
exit;
|
|
}
|
|
|
|
/**
|
|
* PSA_Upgrade — thin wrapper around version_compare + dbDelta.
|
|
*
|
|
* The class exists so the decision logic (is_needed) can be unit-tested as a
|
|
* pure function, while the impure driver (maybe_run) stays isolated.
|
|
*/
|
|
class PSA_Upgrade {
|
|
|
|
/**
|
|
* Option name used to persist the schema version last migrated to.
|
|
*
|
|
* @var string
|
|
*/
|
|
const OPTION_NAME = 'psa_db_version';
|
|
|
|
/**
|
|
* Default stored version for fresh installs. Strictly less than any
|
|
* real released version so version_compare treats it as "older".
|
|
*
|
|
* @var string
|
|
*/
|
|
const DEFAULT_STORED_VERSION = '0.0.0';
|
|
|
|
/**
|
|
* Decide whether a schema upgrade is needed given a stored version and
|
|
* the currently-installed code version. Pure function — no side effects,
|
|
* no WordPress API calls — so it can be exercised in isolation.
|
|
*
|
|
* @param string $stored_version Version string recorded in psa_db_version.
|
|
* @param string $current_version Version string of the running code.
|
|
* @return bool True if an upgrade must run; false otherwise.
|
|
*/
|
|
public static function is_needed( $stored_version, $current_version ) {
|
|
return version_compare( $stored_version, $current_version, '<' );
|
|
}
|
|
|
|
/**
|
|
* Run database upgrades when the installed code version is newer than
|
|
* the stored psa_db_version option. Keeps users from needing to
|
|
* deactivate/reactivate the plugin after a schema change.
|
|
*
|
|
* Side effects: reads psa_db_version option; on upgrade, calls
|
|
* PSA_Cost_Tracker::create_table() and writes psa_db_version.
|
|
*
|
|
* @return void
|
|
*/
|
|
public static function maybe_run() {
|
|
$stored = get_option( self::OPTION_NAME, self::DEFAULT_STORED_VERSION );
|
|
if ( ! self::is_needed( $stored, PSA_VERSION ) ) {
|
|
return;
|
|
}
|
|
|
|
// Re-run CREATE TABLE via dbDelta — additive schema changes (new
|
|
// columns, new indexes) are applied automatically.
|
|
PSA_Cost_Tracker::create_table();
|
|
|
|
update_option( self::OPTION_NAME, PSA_VERSION, false );
|
|
}
|
|
}
|