Adopt reusable CI standard + 300-line splits (#167)

ci: adopt estate reusable CI + split 300-line violations (v0.22.0) Squash merge of PR #167 (claude/adopt-ci-20260616) Head: dc5145cd92 Agent-Session: deploy-operator-2026-06-16
2026-06-16 22:01:45 +07:00
parent d770e8a86a
commit 110c681c57
25 changed files with 1059 additions and 1026 deletions
--- a/.github/mu-plugins/prautoblogger-deploy-receiver.php
+++ b/.github/mu-plugins/prautoblogger-deploy-receiver.php
@@ -35,25 +35,33 @@ add_action( 'rest_api_init', 'prautoblogger_deploy_register_route' );
 * Register the deploy REST route.
 */
 function prautoblogger_deploy_register_route(): void {
-	register_rest_route( 'prautoblogger-deploy/v1', '/deploy', [
-		'methods'             => 'POST',
-		'callback'            => 'prautoblogger_deploy_handle',
-		'permission_callback' => 'prautoblogger_deploy_check_auth',
-	] );
+	register_rest_route(
+		'prautoblogger-deploy/v1',
+		'/deploy',
+		array(
+			'methods'             => 'POST',
+			'callback'            => 'prautoblogger_deploy_handle',
+			'permission_callback' => 'prautoblogger_deploy_check_auth',
+		)
+	);

 	// Health check endpoint (GET) — useful for monitoring.
-	register_rest_route( 'prautoblogger-deploy/v1', '/status', [
-		'methods'             => 'GET',
-		'callback'            => function () {
-			return [
-				'status'  => 'ready',
-				'plugin'  => is_dir( WP_PLUGIN_DIR . '/prautoblogger' ) ? 'installed' : 'not_installed',
-				'active'  => is_plugin_active( 'prautoblogger/prautoblogger.php' ),
-				'version' => prautoblogger_deploy_get_installed_version(),
-			];
-		},
-		'permission_callback' => 'prautoblogger_deploy_check_auth',
-	] );
+	register_rest_route(
+		'prautoblogger-deploy/v1',
+		'/status',
+		array(
+			'methods'             => 'GET',
+			'callback'            => function () {
+				return array(
+					'status'  => 'ready',
+					'plugin'  => is_dir( WP_PLUGIN_DIR . '/prautoblogger' ) ? 'installed' : 'not_installed',
+					'active'  => is_plugin_active( 'prautoblogger/prautoblogger.php' ),
+					'version' => prautoblogger_deploy_get_installed_version(),
+				);
+			},
+			'permission_callback' => 'prautoblogger_deploy_check_auth',
+		)
+	);
 }

 /**
@@ -78,7 +86,7 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
 		return new WP_Error(
 			'rate_limited',
 			'Deploy in progress or recently completed. Wait 60 seconds.',
-			[ 'status' => 429 ]
+			array( 'status' => 429 )
 		);
 	}
 	set_transient( 'prautoblogger_deploy_lock', time(), 60 );
@@ -87,7 +95,7 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
 	$files = $request->get_file_params();
 	if ( empty( $files['plugin']['tmp_name'] ) || ! is_uploaded_file( $files['plugin']['tmp_name'] ) ) {
 		delete_transient( 'prautoblogger_deploy_lock' );
-		return new WP_Error( 'no_file', 'No plugin zip uploaded.', [ 'status' => 400 ] );
+		return new WP_Error( 'no_file', 'No plugin zip uploaded.', array( 'status' => 400 ) );
 	}

 	$tmp_file = $files['plugin']['tmp_name'];
@@ -96,11 +104,11 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
 	$zip = new ZipArchive();
 	if ( true !== $zip->open( $tmp_file ) ) {
 		delete_transient( 'prautoblogger_deploy_lock' );
-		return new WP_Error( 'invalid_zip', 'Uploaded file is not a valid zip.', [ 'status' => 400 ] );
+		return new WP_Error( 'invalid_zip', 'Uploaded file is not a valid zip.', array( 'status' => 400 ) );
 	}

 	$has_main_file = false;
-	for ( $i = 0; $i < $zip->numFiles; $i++ ) {
+	for ( $i = 0; $i < $zip->numFiles; $i++ ) { // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
 		if ( 'prautoblogger/prautoblogger.php' === $zip->getNameIndex( $i ) ) {
 			$has_main_file = true;
 			break;
@@ -113,7 +121,7 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
 		return new WP_Error(
 			'invalid_plugin',
 			'Zip must contain prautoblogger/prautoblogger.php at root.',
-			[ 'status' => 400 ]
+			array( 'status' => 400 )
 		);
 	}

@@ -143,7 +151,7 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
 				activate_plugin( 'prautoblogger/prautoblogger.php' );
 			}
 			delete_transient( 'prautoblogger_deploy_lock' );
-			return new WP_Error( 'backup_failed', 'Could not backup current plugin.', [ 'status' => 500 ] );
+			return new WP_Error( 'backup_failed', 'Could not backup current plugin.', array( 'status' => 500 ) );
 		}
 	}

@@ -161,7 +169,7 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
 		}
 		delete_transient( 'prautoblogger_deploy_lock' );
 		error_log( '[PRAutoBlogger Deploy] Extraction failed. Rolled back to previous version.' );
-		return new WP_Error( 'extract_failed', 'Zip extraction failed. Rolled back.', [ 'status' => 500 ] );
+		return new WP_Error( 'extract_failed', 'Zip extraction failed. Rolled back.', array( 'status' => 500 ) );
 	}

 	// 7. Activate plugin.
@@ -178,7 +186,7 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
 		return new WP_Error(
 			'activation_failed',
 			'Plugin activation failed: ' . $activation_result->get_error_message() . '. Rolled back.',
-			[ 'status' => 500 ]
+			array( 'status' => 500 )
 		);
 	}

@@ -188,18 +196,23 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
 	}

 	$old_version = prautoblogger_deploy_get_installed_version();
-	error_log( sprintf(
-		'[PRAutoBlogger Deploy] Successfully deployed v%s (was: %s) at %s',
-		$incoming_version,
-		$old_version ?: 'fresh install',
-		gmdate( 'Y-m-d H:i:s' )
-	) );
+	error_log(
+		sprintf(
+			'[PRAutoBlogger Deploy] Successfully deployed v%s (was: %s) at %s',
+			$incoming_version,
+			$old_version ? $old_version : 'fresh install',
+			gmdate( 'Y-m-d H:i:s' )
+		)
+	);

-	return new WP_REST_Response( [
-		'success' => true,
-		'version' => $incoming_version,
-		'message' => "PRAutoBlogger v{$incoming_version} deployed and activated.",
-	], 200 );
+	return new WP_REST_Response(
+		array(
+			'success' => true,
+			'version' => $incoming_version,
+			'message' => "PRAutoBlogger v{$incoming_version} deployed and activated.",
+		),
+		200
+	);
 }

 /**
@@ -210,7 +223,7 @@ function prautoblogger_deploy_get_installed_version(): string {
 	if ( ! file_exists( $main_file ) ) {
 		return '';
 	}
-	$data = get_file_data( $main_file, [ 'Version' => 'Version' ] );
+	$data = get_file_data( $main_file, array( 'Version' => 'Version' ) );
 	return $data['Version'] ?? '';
 }

--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1,114 +1,34 @@
-name: CI — Lint & Test
-
-# Runs on every PR and every push to main. Validates PHPUnit tests + lint +
-# coding standards before deploy can happen. deploy.yml on main continues to
-# run its own validate job as a belt-and-suspenders check, but this CI workflow
-# is what gives PRs an immediate signal so fixes happen before merge.
+##
+# CI caller — PRAutoBlogger
+#
+# Thin caller that delegates to the reusable estate CI workflow in peptide-e2e.
+# workflow_call is required so deploy.yml can gate on this workflow via
+# `uses: ./.github/workflows/ci.yml` (the workflow_call trigger enables that).
+#
+# Permissions: contents: write is required at the caller level so the reusable
+# workflow's phpcbf auto-commit job can push fixes back to the PR branch.
+# (GitHub enforces that callers cannot be escalated beyond their declared scope.)
+#
+# tests: brain-monkey — no WP install or DB required; Brain Monkey mocking only.
+# line_limit_paths: includes — estate hard 300-line rule applied to includes/.
+##
+name: CI

 on:
+  pull_request: {}
  push:
    branches: [main]
-  pull_request:
-    branches: [main]
+  workflow_call: {}

 permissions:
-  contents: read
+  contents: write

 jobs:
-  php-lint:
-    name: PHP Lint (${{ matrix.php }})
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        php: ['8.1', '8.2', '8.3']
-    steps:
-      - uses: actions/checkout@v4
-      - name: Setup PHP ${{ matrix.php }}
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: ${{ matrix.php }}
-          coverage: none
-      - name: Syntax check all PHP files
-        # Exclude .github/mu-plugins — those run on the production server (PHP 8+)
-        # and may use PHP 8+ syntax (union types etc.) that older versions reject.
-        run: |
-          set -e
-          find . -name '*.php' \
-            -not -path './vendor/*' \
-            -not -path './node_modules/*' \
-            -not -path './.git/*' \
-            -not -path './.github/*' \
-            -print0 | xargs -0 -n1 -P4 php -l > /dev/null
-
-  phpcs:
-    name: PHPCS (WordPress standards)
-    runs-on: ubuntu-latest
-    continue-on-error: false  # strict after PHPCS cleanup in v0.8.3
-    permissions:
-      contents: write  # allows phpcbf auto-fix commits back to the PR branch
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          ref: ${{ github.head_ref || github.ref_name }}
-          token: ${{ secrets.GITHUB_TOKEN }}
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: '8.1'
-          coverage: none
-          tools: composer:v2, phpcs
-      - name: Install WordPress Coding Standards
-        run: |
-          composer global config --no-plugins allow-plugins.dealerdirect/phpcodesniffer-composer-installer true
-          composer global require --no-interaction \
-            "dealerdirect/phpcodesniffer-composer-installer:^1.0" \
-            "wp-coding-standards/wpcs:^3.0" \
-            "phpcsstandards/phpcsutils:^1.0" \
-            "phpcsstandards/phpcsextra:^1.0"
-      - name: Auto-fix with phpcbf (commit back to branch if changed)
-        # phpcbf exits 1 when it makes fixes, 0 when nothing to fix — both are success here.
-        # Commits made via GITHUB_TOKEN do not trigger a new CI run (GitHub prevents loops).
-        run: |
-          phpcbf --standard=phpcs.xml \
-            --extensions=php \
-            --ignore=vendor/*,tests/*,node_modules/* \
-            includes/ prautoblogger.php uninstall.php || true
-          if ! git diff --quiet; then
-            git config user.name "peptiderepo"
-            git config user.email "peptiderepo@users.noreply.github.com"
-            git add -A
-            git commit -m "style: auto-fix PHPCS violations via phpcbf"
-            git push
-          fi
-      - name: Run PHPCS (only non-auto-fixable violations can fail here)
-        run: |
-          phpcs --standard=phpcs.xml \
-            --extensions=php \
-            --ignore=vendor/*,tests/*,node_modules/* \
-            --warning-severity=0 \
-            --report=full \
-            includes/ prautoblogger.php uninstall.php
-
-  phpunit:
-    name: PHPUnit (PHP ${{ matrix.php }})
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        php: ['8.1', '8.2', '8.3']
-    steps:
-      - uses: actions/checkout@v4
-      - name: Setup PHP ${{ matrix.php }}
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: ${{ matrix.php }}
-          coverage: none
-          tools: composer:v2
-      - name: Install composer dependencies
-        run: composer install --no-progress --no-interaction --prefer-dist
-      - name: Run PHPUnit (Brain Monkey — no WP install required)
-        run: vendor/bin/phpunit --testdox
+  ci:
+    uses: peptiderepo/peptide-e2e/.github/workflows/ci.yml@main
+    with:
+      tests: brain-monkey
+    secrets: inherit

  check-constants:
    name: Check PRAUTOBLOGGER_* constants
@@ -126,7 +46,8 @@ jobs:
        # by defined() at the reference site. Prevents the v0.19.0 incident
        # class (constant deleted from bootstrap, test fallback masks the gap).
        run: php scripts/check-constants.php
-      - name: Self-test check-constants guard (v0.21.0)
-        # Verifies the guard script itself catches a synthetic missing constant.
-        # Exit 2 = self-test failure (scanner is broken). Exit 0 = scanner works.
+      - name: Self-test check-constants scanner
+        # Verifies the scanner itself can detect the failure cases it was
+        # designed to catch. If the scanner regresses, this step fails CI.
+        # Added v0.21.0; restored in v0.22.0 (was accidentally dropped in rewrite).
        run: php scripts/check-constants.php --self-test
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -9,28 +9,16 @@ concurrency:
  cancel-in-progress: true

 jobs:
-  validate:
-    name: PHP Lint Gate
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - uses: shivammathur/setup-php@v2
-        with:
-          php-version: '8.1'
-          coverage: none
-      - name: PHP Lint Check
-        run: |
-          set -e
-          find . -name '*.php' \
-            -not -path './vendor/*' \
-            -not -path './node_modules/*' \
-            -not -path './.git/*' \
-            -not -path './.github/*' \
-            -print0 | xargs -0 -n1 -P4 php -l > /dev/null
+  ci:
+    name: CI Gate (reusable)
+    uses: ./.github/workflows/ci.yml
+    permissions:
+      contents: write
+    secrets: inherit

  deploy:
    name: Deploy (shared pipeline)
-    needs: validate
+    needs: ci
    uses: peptiderepo/peptide-e2e/.github/workflows/deploy-app.yml@main
    with:
      target_path: wp-content/plugins/prautoblogger