peptide-repo/prautoblogger
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

v0.8.1: orphan research-row reaper + GA4 description fix

Browse Source 
* feat(cost): persist run_id on generated posts + back-populate for v0.8.1 reaper

The orphan-research-row reaper (upcoming commit) needs a cheap way to
answer "which posts belong to this run_id?" when amortizing a stranded
`llm_research` row back to its siblings. Relying on the generation_log
post_id column is circular: if the pipeline died before amortize_research
ran, we'd trust the same table we're trying to repair.

- `Publisher::build_meta()` now accepts `?string $run_id` and writes
  `_prautoblogger_run_id => $run_id` when non-empty. Null/empty preserves
  existing null-safe legacy behaviour.
- `Publisher::create_post()` forwards the $run_id it already receives
  into build_meta — one-line plumbing, no new parameters at call sites.
- `Activator::backpopulate_run_id_meta_v081()` runs once per site,
  gated by `prautoblogger_migrated_run_id_meta_v081` option. Walks
  `wp_prautoblogger_generation_log`, pairs (post_id, min(run_id)),
  writes `_prautoblogger_run_id` on any post that doesn't already have
  it. Uses `metadata_exists()` so it's a no-op on re-run.
- Activator also schedules the new daily `prautoblogger_reap_orphan_research_rows`
  cron at 03:15 — 15 min after the primary generation cron — so live
  pipelines have time to finish amortizing cleanly before the reaper scans.
- Deactivator unschedules the new hook alongside the existing cron hooks.

No user-visible behaviour change yet. The reaper handler ships in the
next commit; this one just ensures it will have the data + schedule it
needs when it lands.

Part of the v0.8.1 bundle (thread research-cost-reaper).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(cost): daily reaper for orphan llm_research rows

Implements the orphan-research-row reaper per thread research-cost-reaper
seq 1. When a pipeline dies between post creation and
`Post_Assembler::amortize_research_costs()` (Hostinger exec kill, OOM,
LiteSpeed cut, fatal), the shared research row stays in
`wp_prautoblogger_generation_log` with `post_id = NULL` and sibling
articles' cost popovers understate their true spend.

New class `PRAutoBlogger_Research_Reaper` owns:

- `on_cron()` — WP-Cron entrypoint hooked to the daily
  `prautoblogger_reap_orphan_research_rows` event (already scheduled
  by the Activator in the previous commit at 03:15).
- `reap()` — returns a `{reaped, deleted, skipped}` summary. For each
  orphan `llm_research` row older than 1 hour (grace window for live
  pipelines):
  - `_prautoblogger_run_id` post_meta primary lookup.
  - Falls back to distinct post_ids in gen_log with the same run_id.
  - If ≥1 post found → delegate to the existing idempotent
    `Post_Assembler::amortize_research_costs()`. That method inserts
    the per-article rows and deletes the original orphan in one pass,
    so the reaper is idempotent on re-run.
  - If 0 posts found AND orphan is >7 days old → delete outright as
    sunk cost with nothing to attribute to.
  - Else → skip; try again the next day.
- Never throws. DB errors caught and logged WARNING.

New WP-CLI command `wp prautoblogger reap-research` registered in the
main loader when `WP_CLI` is defined — manual ops trigger that prints
the same summary.

Departure from the CTO's spec: the reap logic lives on
`Research_Reaper` instead of `Post_Assembler`. Placing it on
Post_Assembler pushed that file to 391 lines, over the 300-line cap.
Moving it to the thin class colocates the attribution logic with the
cron/CLI plumbing that triggers it. `amortize_research_costs()` stays
on Post_Assembler — the reaper delegates to it unchanged. Flagged for
CTO review.

Part of the v0.8.1 bundle (thread research-cost-reaper).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(cost): ResearchReaperTest — five cases per spec

Covers the five scenarios from convo thread research-cost-reaper seq 1:

- test_reaps_orphan_with_matching_run_id_posts — meta lookup returns
  two post IDs; reaper delegates to amortize_research_costs which
  inserts two rows and deletes the orphan.
- test_skips_orphan_within_grace_period — the SELECT's
  `created_at < now - 1h` clause filters fresh orphans at the DB; the
  reaper's stats stay zero and no side effects fire.
- test_deletes_orphan_with_no_articles_after_7_days — orphan is 8 days
  old, zero siblings via meta or gen_log; reaper deletes outright.
- test_falls_back_to_gen_log_when_post_meta_missing — meta returns
  empty (legacy pre-v0.8.1 post); gen_log has two distinct post_ids;
  amortize still runs.
- test_idempotent_on_repeat_run — second pass on a cleaned state
  returns 0/0/0 with no inserts or deletes.

All DB interaction mocked via $wpdb stub — no real DB round-trips.
Fixtures are driven by property mutations in the test methods so
PHPUnit's "one stub per method" restriction on mocks doesn't bite.

Part of the v0.8.1 bundle.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(v0.8.1): version bump + CHANGELOG + ARCHITECTURE.md for reaper

Bump plugin header and PRAUTOBLOGGER_VERSION 0.8.0 → 0.8.1. Patch
bump — the reaper is internal infrastructure; no user-visible UX
change.

CHANGELOG:
- Fixed: orphan `llm_research` rows now reaped daily.
- Added: WP-CLI `wp prautoblogger reap-research`; `_prautoblogger_run_id`
  post_meta is now written by Publisher on every post.

ARCHITECTURE.md:
- Decision #13 (Run-ID based log linking) cross-refs the new post_meta.
- New Decision #19 documents the reaper's scan/amortize/delete policy,
  the 1-hour grace window, the 7-day stale cutoff, and the one-shot
  activator back-populate migration.

DB schema unchanged — no PRAUTOBLOGGER_DB_VERSION bump.

Final commit of the v0.8.1 bundle.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(cost): widen $wpdb mock so ResearchReaperTest actually runs

BaseTestCase::create_mock_wpdb() only adds methods
[prepare, get_var, get_results, insert, query, get_row, update] — the
reaper and amortize_research_costs also call `delete` and `get_col`,
which the default mock can't stub. CI on PR #100 fired all five new
ResearchReaperTest cases as errors at the first `->method('delete')`
call during setUp.

Fix: build a bespoke $wpdb mock in this file's setUp with the full
superset of methods it needs. Self-contained; no change to
BaseTestCase so existing tests aren't affected.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(cost): filter gen_log inserts from event_log inserts in reaper tests

CI on ec1efee showed the two reap-and-amortize tests failing because
`assertCount(2, $this->inserted_rows)` was seeing 4 rows, not 2. Root
cause: the Logger singleton writes INFO lines via `$wpdb->insert` into
the event_log table — the reaper logs once ("Reaped...") and amortize
logs once ("Amortized LLM research cost...") before the two per-post
gen_log inserts, so the capture ended up with 4 total rows.

Add a `gen_log_inserts()` helper that filters the capture down to rows
whose `__table` contains "generation_log" — the assertions on
attribution count should only measure the actual cost inserts, not
incidental log writes. Two tests updated; logic unchanged.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(admin): correct misleading GA4 Property ID description

The GA4 client at includes/core/class-ga4-client.php:85 already wraps the
property_id option with "properties/" in the outbound URL path. The admin
description told users to enter "properties/XXXXXXXXX" — which would have
produced a double-prefixed URL (properties/properties/XXXXXXXXX) and a
guaranteed 404 from the Data API. Description now asks for digits only,
matching actual code behavior.

No code logic change — UX copy + CHANGELOG only. Flagged by CEO while
inspecting the Analytics tab; folded into the in-flight v0.8.1 PR per
CTO call rather than cutting a separate patch.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: peptiderepo <peptiderepo@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
peptiderepo
2026-04-21 09:48:34 +07:00
committed by GitHub
parent 188e6603dd
commit 33d3ba4ea1
10 changed files with 593 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

286
tests/unit/Core/ResearchReaperTest.php Normal file
View File

@@ -0,0 +1,286 @@
<?php
/**
* Tests for PRAutoBlogger_Research_Reaper.
*
* Exercises the five scenarios spec'd in convo thread
* research-cost-reaper/01-cto-handoff.md: meta-based reap, grace-period
* skip, 7-day stale delete, gen_log fallback when meta is missing, and
* idempotency on repeat runs.
*
* All DB work is mocked via a $wpdb stub — no real database round-trips.
*
* @package PRAutoBlogger\Tests\Core
*/
namespace PRAutoBlogger\Tests\Core;
use PRAutoBlogger\Tests\BaseTestCase;
use Brain\Monkey\Functions;
class ResearchReaperTest extends BaseTestCase {
/**
* @var \PHPUnit\Framework\MockObject\MockObject Mock $wpdb.
*/
private $wpdb;
/**
* Captured INSERT rows (from amortize_research_costs delegating to $wpdb->insert).
*
* @var array<int, array<string, mixed>>
*/
private array $inserted_rows = [];
/**
* Captured DELETE calls: [$table, $where-array].
*
* @var array<int, array{0: string, 1: array<string, mixed>}>
*/
private array $deleted_rows = [];
/**
* Fixture: the rows get_results should hand back for the orphan scan.
*
* @var array<int, object>
*/
private array $orphan_fixtures = [];
/**
* Fixture: post IDs the reaper's fallback gen_log query should return.
*
* @var int[]
*/
private array $gen_log_post_ids = [];
protected function setUp(): void {
parent::setUp();
$this->inserted_rows = [];
$this->deleted_rows = [];
$this->orphan_fixtures = [];
$this->gen_log_post_ids = [];
// Bespoke $wpdb mock — BaseTestCase::create_mock_wpdb() doesn't
// stub `delete` or `get_col`, both of which the reaper + amortize
// call into. Wide-method mock keeps the test scope self-contained.
$this->wpdb = $this->getMockBuilder( \stdClass::class )
->addMethods( [ 'prepare', 'get_var', 'get_results', 'get_row', 'get_col', 'insert', 'delete', 'update', 'query' ] )
->getMock();
$this->wpdb->prefix = 'wp_';
$this->wpdb->insert_id = 1;
$this->wpdb->last_error = '';
$this->wpdb->prab_cost_logs = 'wp_prab_cost_logs';
$this->wpdb->method( 'insert' )->willReturnCallback(
function ( $table, $row ) {
$this->inserted_rows[] = array_merge( [ '__table' => $table ], $row );
return 1;
}
);
$this->wpdb->method( 'delete' )->willReturnCallback(
function ( $table, $where ) {
$this->deleted_rows[] = [ (string) $table, (array) $where ];
return 1;
}
);
// prepare() returns its args joined so we can pattern-match in get_* stubs.
$this->wpdb->method( 'prepare' )->willReturnCallback(
function ( $sql, ...$args ) {
return $sql . '|' . implode( '|', array_map( 'strval', $args ) );
}
);
// get_results routes by SQL fragment between the reaper's orphan scan
// and the occasional Logger insert probes.
$this->wpdb->method( 'get_results' )->willReturnCallback(
function ( $sql ) {
if ( false !== stripos( (string) $sql, "post_id IS NULL AND created_at <" ) ) {
return $this->orphan_fixtures;
}
return [];
}
);
// get_row serves amortize_research_costs's research-row lookup.
$this->wpdb->method( 'get_row' )->willReturnCallback(
function ( $sql ) {
foreach ( $this->orphan_fixtures as $o ) {
if ( false !== stripos( (string) $sql, (string) $o->run_id ) ) {
return (object) [
'id' => $o->id,
'estimated_cost' => $o->estimated_cost ?? 0.50,
'provider' => $o->provider ?? 'openrouter',
'model' => $o->model ?? 'gemini-flash',
'prompt_tokens' => $o->prompt_tokens ?? 1000,
'completion_tokens' => $o->completion_tokens ?? 500,
];
}
}
return null;
}
);
// get_col is the reaper's fallback "posts by run_id" and amortize's
// "distinct post_ids" query — both read from the same fixture.
$this->wpdb->method( 'get_col' )->willReturnCallback(
fn() => array_map( 'strval', $this->gen_log_post_ids )
);
$GLOBALS['wpdb'] = $this->wpdb;
$this->stub_get_option( [
'prautoblogger_log_level' => 'info',
] );
// Reaper uses get_posts to look up sibling posts via post_meta.
Functions\when( 'get_posts' )->justReturn( [] );
}
protected function tearDown(): void {
unset( $GLOBALS['wpdb'] );
parent::tearDown();
}
/**
* Return only the `generation_log` inserts from the capture — filters out
* the `event_log` rows that Logger::instance()->info() writes as a side
* effect of the reaper + amortize's own progress logging.
*
* @return array<int, array<string, mixed>>
*/
private function gen_log_inserts(): array {
return array_values( array_filter(
$this->inserted_rows,
static fn( $row ) => false !== strpos( (string) ( $row['__table'] ?? '' ), 'generation_log' )
) );
}
/**
* Helper: seed the orphan list returned by the reaper's primary SELECT.
*
* @param array<int, array{id: int, run_id: string, created_at: string, estimated_cost?: float, provider?: string, model?: string, prompt_tokens?: int, completion_tokens?: int}> $orphans
*/
private function seed_orphans( array $orphans ): void {
$this->orphan_fixtures = array_map(
static fn( $r ) => (object) $r,
$orphans
);
}
/**
* Helper: set the post_ids the gen_log fallback query returns.
*
* @param int[] $post_ids
*/
private function seed_gen_log_posts_for_run( array $post_ids ): void {
$this->gen_log_post_ids = $post_ids;
}
/**
* 1. Reap succeeds via post_meta primary lookup.
*
* Orphan row is >1h old, `_prautoblogger_run_id` meta returns two
* post IDs, amortize inserts two attributed rows and deletes the
* original orphan.
*/
public function test_reaps_orphan_with_matching_run_id_posts(): void {
$old_ts = gmdate( 'Y-m-d H:i:s', time() - ( 2 * HOUR_IN_SECONDS ) );
$this->seed_orphans( [ [ 'id' => 99, 'run_id' => 'run-abc', 'created_at' => $old_ts, 'estimated_cost' => 0.40 ] ] );
// In the v0.8.1 world both sources agree. Meta is the reaper's gate;
// gen_log also has rows so `amortize_research_costs()` can do its
// own internal post-count query.
Functions\when( 'get_posts' )->alias(
static fn( $args ) => ( '_prautoblogger_run_id' === ( $args['meta_key'] ?? '' ) && 'run-abc' === ( $args['meta_value'] ?? '' ) )
? [ 101, 102 ]
: []
);
$this->seed_gen_log_posts_for_run( [ 101, 102 ] );
$stats = \PRAutoBlogger_Research_Reaper::reap();
$this->assertSame( 1, $stats['reaped'] );
$this->assertSame( 0, $stats['deleted'] );
$this->assertSame( 0, $stats['skipped'] );
$this->assertCount(
2,
$this->gen_log_inserts(),
'One amortized row per post should be inserted into the generation_log.'
);
// Original orphan deleted by amortize_research_costs.
$this->assertNotEmpty( array_filter( $this->deleted_rows, static fn( $d ) => ( $d[1]['id'] ?? null ) === 99 ) );
}
/**
* 2. Orphan within the 1-hour grace window is left alone — a live
* pipeline may still be in the middle of its own amortize step.
*/
public function test_skips_orphan_within_grace_period(): void {
// The primary SELECT filters on `created_at < (now - 1h)`, so a
// fresh orphan is excluded from the result set at the DB boundary.
// We simulate that by returning an empty orphan list.
$this->seed_orphans( [] );
Functions\when( 'get_posts' )->justReturn( [ 101, 102 ] );
$stats = \PRAutoBlogger_Research_Reaper::reap();
$this->assertSame( 0, $stats['reaped'] );
$this->assertSame( 0, $stats['deleted'] );
$this->assertSame( 0, $stats['skipped'] );
$this->assertEmpty( $this->inserted_rows );
$this->assertEmpty( $this->deleted_rows );
}
/**
* 3. Orphan older than 7 days with zero matching posts is deleted
* outright — research cost is sunk with nothing to attribute to.
*/
public function test_deletes_orphan_with_no_articles_after_7_days(): void {
$stale_ts = gmdate( 'Y-m-d H:i:s', time() - ( 8 * DAY_IN_SECONDS ) );
$this->seed_orphans( [ [ 'id' => 77, 'run_id' => 'run-dead', 'created_at' => $stale_ts ] ] );
// No posts via meta, no posts via gen_log.
Functions\when( 'get_posts' )->justReturn( [] );
$this->seed_gen_log_posts_for_run( [] );
$stats = \PRAutoBlogger_Research_Reaper::reap();
$this->assertSame( 0, $stats['reaped'] );
$this->assertSame( 1, $stats['deleted'] );
$this->assertNotEmpty( array_filter( $this->deleted_rows, static fn( $d ) => ( $d[1]['id'] ?? null ) === 77 ) );
}
/**
* 4. When `_prautoblogger_run_id` post_meta is absent (legacy posts
* predating v0.8.1), the reaper falls back to querying gen_log for
* distinct post_ids carrying the same run_id.
*/
public function test_falls_back_to_gen_log_when_post_meta_missing(): void {
$old_ts = gmdate( 'Y-m-d H:i:s', time() - ( 2 * HOUR_IN_SECONDS ) );
$this->seed_orphans( [ [ 'id' => 55, 'run_id' => 'run-legacy', 'created_at' => $old_ts, 'estimated_cost' => 0.30 ] ] );
// Meta lookup returns nothing.
Functions\when( 'get_posts' )->justReturn( [] );
// But gen_log has two posts with this run_id.
$this->seed_gen_log_posts_for_run( [ 201, 202 ] );
$stats = \PRAutoBlogger_Research_Reaper::reap();
$this->assertSame( 1, $stats['reaped'] );
$this->assertCount( 2, $this->gen_log_inserts() );
}
/**
* 5. A second reap run is a no-op — the first run deleted the orphan
* and inserted amortized per-article rows, so the scan returns empty.
*/
public function test_idempotent_on_repeat_run(): void {
// Simulate "already reaped" state: scan returns no orphans.
$this->seed_orphans( [] );
$stats_1 = \PRAutoBlogger_Research_Reaper::reap();
$stats_2 = \PRAutoBlogger_Research_Reaper::reap();
$this->assertSame( 0, $stats_1['reaped'] );
$this->assertSame( 0, $stats_2['reaped'] );
$this->assertEmpty( $this->inserted_rows );
$this->assertEmpty( $this->deleted_rows );
}
}