From 7217c154bbe238e9319520f574ba3858f1e57f8e Mon Sep 17 00:00:00 2001
From: peptiderepo <peptiderepo@users.noreply.github.com>
Date: Tue, 16 Jun 2026 14:04:40 +0000
Subject: [PATCH] fix: resolve pre-existing PHPCS violations (Yoda conditions +
 short ternaries)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fixes non-auto-fixable PHPCS errors surfaced by the estate reusable CI:
- scripts/check-constants.php: Yoda conditions at lines 140, 201
- templates/admin/ideas-browser.php: Elvis (?:) → explicit ternary (line 75)
- templates/admin/review-queue.php: Elvis (?:) → explicit ternaries (lines 144, 161-163)
- templates/admin/metabox-generation-info.php: Elvis (?:) → explicit ternaries (7 lines)
- .github/mu-plugins/prautoblogger-deploy-receiver.php: phpcs:ignore for
  ZipArchive->numFiles (native PHP property, can't be snake_cased); Elvis (?:) fix

All violations were pre-existing; none introduced by this PR.

Agent-Session: claude/adopt-ci-20260616
---
 .../mu-plugins/prautoblogger-deploy-receiver.php   |  4 ++--
 scripts/check-constants.php                        |  4 ++--
 templates/admin/ideas-browser.php                  |  3 ++-
 templates/admin/metabox-generation-info.php        | 14 +++++++-------
 templates/admin/review-queue.php                   |  8 ++++----
 5 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/.github/mu-plugins/prautoblogger-deploy-receiver.php b/.github/mu-plugins/prautoblogger-deploy-receiver.php
index 48475f0..0ba4f83 100644
--- a/.github/mu-plugins/prautoblogger-deploy-receiver.php
+++ b/.github/mu-plugins/prautoblogger-deploy-receiver.php
@@ -108,7 +108,7 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
 	}
 
 	$has_main_file = false;
-	for ( $i = 0; $i < $zip->numFiles; $i++ ) {
+	for ( $i = 0; $i < $zip->numFiles; $i++ ) { // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
 		if ( 'prautoblogger/prautoblogger.php' === $zip->getNameIndex( $i ) ) {
 			$has_main_file = true;
 			break;
@@ -200,7 +200,7 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
 		sprintf(
 			'[PRAutoBlogger Deploy] Successfully deployed v%s (was: %s) at %s',
 			$incoming_version,
-			$old_version ?: 'fresh install',
+			$old_version ? $old_version : 'fresh install',
 			gmdate( 'Y-m-d H:i:s' )
 		)
 	);
diff --git a/scripts/check-constants.php b/scripts/check-constants.php
index 1b83efd..60a9e87 100644
--- a/scripts/check-constants.php
+++ b/scripts/check-constants.php
@@ -137,7 +137,7 @@ $errors = array();
 
 foreach ( $php_files as $php_path ) {
 	$raw = file_get_contents( $php_path );
-	if ( $raw === false ) {
+	if ( false === $raw ) {
 		fwrite( STDERR, "WARNING: cannot read {$php_path} -- skipping\n" );
 		continue;
 	}
@@ -198,7 +198,7 @@ foreach ( $php_files as $php_path ) {
 // 4. Report results.
 // -------------------------------------------------------------------------
 
-if ( $errors !== array() ) {
+if ( array() !== $errors ) {
 	fwrite( STDERR, "\nFAIL -- Unguarded undefined PRAUTOBLOGGER_* constants:\n\n" );
 	foreach ( $errors as [ $php_path, $lineno, $name, $line_text ] ) {
 		fwrite( STDERR, "  {$php_path}:{$lineno}: {$name}\n" );
diff --git a/templates/admin/ideas-browser.php b/templates/admin/ideas-browser.php
index a04efac..27d4a71 100644
--- a/templates/admin/ideas-browser.php
+++ b/templates/admin/ideas-browser.php
@@ -72,7 +72,8 @@ $base_url = admin_url( 'admin.php?page=prautoblogger-ideas' );
 			<tbody>
 				<?php foreach ( $rows as $row ) : ?>
 					<?php
-					$meta       = json_decode( $row['metadata_json'] ?? '{}', true ) ?: array();
+					$decoded    = json_decode( $row['metadata_json'] ?? '{}', true );
+					$meta       = is_array( $decoded ) ? $decoded : array();
 					$suggested  = $meta['suggested_title'] ?? '';
 					$key_points = $meta['key_points'] ?? array();
 					$keywords   = $meta['target_keywords'] ?? array();
diff --git a/templates/admin/metabox-generation-info.php b/templates/admin/metabox-generation-info.php
index 8781722..2362520 100755
--- a/templates/admin/metabox-generation-info.php
+++ b/templates/admin/metabox-generation-info.php
@@ -27,19 +27,19 @@ $meta = array(
 <div class="prautoblogger-metabox">
 	<p>
 		<strong><?php esc_html_e( 'Generated:', 'prautoblogger' ); ?></strong>
-		<?php echo esc_html( $meta['generated_at'] ?: __( 'Unknown', 'prautoblogger' ) ); ?>
+		<?php echo esc_html( $meta['generated_at'] ? $meta['generated_at'] : __( 'Unknown', 'prautoblogger' ) ); ?>
 	</p>
 	<p>
 		<strong><?php esc_html_e( 'Topic:', 'prautoblogger' ); ?></strong>
-		<?php echo esc_html( $meta['topic'] ?: '—' ); ?>
+		<?php echo esc_html( $meta['topic'] ? $meta['topic'] : '—' ); ?>
 	</p>
 	<p>
 		<strong><?php esc_html_e( 'Type:', 'prautoblogger' ); ?></strong>
-		<?php echo esc_html( ucfirst( $meta['type'] ?: 'article' ) ); ?>
+		<?php echo esc_html( ucfirst( $meta['type'] ? $meta['type'] : 'article' ) ); ?>
 	</p>
 	<p>
 		<strong><?php esc_html_e( 'Model:', 'prautoblogger' ); ?></strong>
-		<?php echo esc_html( $meta['model'] ?: '—' ); ?>
+		<?php echo esc_html( $meta['model'] ? $meta['model'] : '—' ); ?>
 	</p>
 	<p>
 		<strong><?php esc_html_e( 'Pipeline:', 'prautoblogger' ); ?></strong>
@@ -47,8 +47,8 @@ $meta = array(
 	</p>
 	<p>
 		<strong><?php esc_html_e( 'Editor Verdict:', 'prautoblogger' ); ?></strong>
-		<span class="prautoblogger-verdict-<?php echo esc_attr( $meta['verdict'] ?: 'unknown' ); ?>">
-			<?php echo esc_html( ucfirst( $meta['verdict'] ?: __( 'Unknown', 'prautoblogger' ) ) ); ?>
+		<span class="prautoblogger-verdict-<?php echo esc_attr( $meta['verdict'] ? $meta['verdict'] : 'unknown' ); ?>">
+			<?php echo esc_html( ucfirst( $meta['verdict'] ? $meta['verdict'] : __( 'Unknown', 'prautoblogger' ) ) ); ?>
 		</span>
 	</p>
 	<?php if ( $meta['quality_score'] ) : ?>
@@ -69,7 +69,7 @@ $meta = array(
 	<?php if ( $meta['keywords'] ) : ?>
 		<p>
 			<strong><?php esc_html_e( 'Keywords:', 'prautoblogger' ); ?></strong>
-			<?php echo esc_html( implode( ', ', json_decode( $meta['keywords'], true ) ?: array() ) ); ?>
+			<?php echo esc_html( implode( ', ', ( json_decode( $meta['keywords'], true ) ? json_decode( $meta['keywords'], true ) : array() ) ) ); ?>
 		</p>
 	<?php endif; ?>
 </div>
diff --git a/templates/admin/review-queue.php b/templates/admin/review-queue.php
index 287a80c..dad6f6d 100644
--- a/templates/admin/review-queue.php
+++ b/templates/admin/review-queue.php
@@ -141,7 +141,7 @@ $bulk_type = isset( $_GET['prautoblogger_bulk_type'] ) ? sanitize_text_field( wp
 						$quality_score = get_post_meta( $post_id, '_prautoblogger_quality_score', true );
 						$generated_at  = get_post_meta( $post_id, '_prautoblogger_generated_at', true );
 						$editor_notes  = get_post_meta( $post_id, '_prautoblogger_editor_notes', true );
-						$verdict_class = 'prautoblogger-verdict-' . sanitize_html_class( $verdict ?: 'pending' );
+						$verdict_class = 'prautoblogger-verdict-' . sanitize_html_class( $verdict ? $verdict : 'pending' );
 						?>
 						<tr data-post-id="<?php echo esc_attr( (string) $post_id ); ?>">
 							<td class="check-column">
@@ -158,9 +158,9 @@ $bulk_type = isset( $_GET['prautoblogger_bulk_type'] ) ? sanitize_text_field( wp
 									<div class="prautoblogger-editor-notes"><?php echo esc_html( $editor_notes ); ?></div>
 								<?php endif; ?>
 							</td>
-							<td><?php echo esc_html( $topic ?: '—' ); ?></td>
-							<td><?php echo esc_html( ucfirst( $article_type ?: 'article' ) ); ?></td>
-							<td><span class="<?php echo esc_attr( $verdict_class ); ?>"><?php echo esc_html( ucfirst( $verdict ?: 'pending' ) ); ?></span></td>
+							<td><?php echo esc_html( $topic ? $topic : '—' ); ?></td>
+							<td><?php echo esc_html( ucfirst( $article_type ? $article_type : 'article' ) ); ?></td>
+							<td><span class="<?php echo esc_attr( $verdict_class ); ?>"><?php echo esc_html( ucfirst( $verdict ? $verdict : 'pending' ) ); ?></span></td>
 							<td><?php echo '' !== $quality_score ? esc_html( $quality_score . '/10' ) : '—'; ?></td>
 							<td><?php echo $generated_at ? esc_html( wp_date( 'M j, g:i A', strtotime( $generated_at ) ) ) : '—'; ?></td>
 							<td class="prautoblogger-queue-actions">