peptide-repo/prautoblogger
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: wire Image B source data — was hardcoded null, never generated

Browse Source 
Root cause: both attach_generated_images() in post-assembler and the
retroactive handler in executor passed null as source_data to the image
pipeline. The pipeline's Image B branch requires non-null source_data
to fire, so Image B was silently skipped on every article since the
feature was built.

Fix: added get_source_data_for_image() to Source_Collector to retrieve
the original Reddit post title/content by source_ids. Post-assembler
now pulls source_ids from the Article_Idea; executor pulls them from
the _prautoblogger_source_ids post meta saved by the publisher.

Also added a regression test proving Image B is skipped when source_data
is null, so this handoff gap will be caught if re-introduced.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
peptiderepo
2026-04-18 08:34:21 +07:00
parent 5b5286ca5b
commit b5e91ba3a6
4 changed files with 98 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
tests/unit/Core/ImagePipelineTest.php
View File

@@ -130,6 +130,45 @@ class ImagePipelineTest extends BaseTestCase {
$this->assertGreaterThan( 0.05, $result['cost_usd'] );
}
/**
* Test that Image B is NOT generated when source_data is null.
*
* This is the regression test for the Image B data-handoff gap:
* post_assembler.php and executor.php both passed null as source_data,
* so the pipeline silently skipped Image B. If this test ever fails
* with `$this->exactly(2)`, it means someone re-broke the handoff.
*/
public function test_image_b_skipped_when_source_data_is_null(): void {
$provider = $this->createMock( \PRAutoBlogger_Image_Provider_Interface::class );
$provider->method( 'estimate_cost' )->willReturn( 0.05 );
$provider->method( 'generate_image' )->willReturn( [
'bytes' => 'fake_image_data',
'mime_type' => 'image/png',
'width' => 1200,
'height' => 630,
'model' => 'flux-1-schnell',
'cost_usd' => 0.05,
'latency_ms' => 2000,
] );
$cost_tracker = $this->createMock( \PRAutoBlogger_Cost_Tracker::class );
$cost_tracker->method( 'would_exceed_budget' )->willReturn( false );
// Only ONE call to log_image_generation — Image A only.
$cost_tracker->expects( $this->exactly( 1 ) )->method( 'log_image_generation' );
$pipeline = new \PRAutoBlogger_Image_Pipeline( $provider, $cost_tracker );
Functions\when( 'get_temp_dir' )->justReturn( '/tmp/' );
Functions\when( 'media_handle_sideload' )->justReturn( 42 );
// Pass null source_data — Image B must NOT fire.
$result = $pipeline->generate_and_attach_images( 1, [ 'post_title' => 'Test' ], null );
$this->assertArrayHasKey( 'image_a_id', $result );
$this->assertArrayNotHasKey( 'image_b_id', $result );
}
/**
* Test graceful handling when image generation fails.
*/