* feat(cost): persist run_id on generated posts + back-populate for v0.8.1 reaper
The orphan-research-row reaper (upcoming commit) needs a cheap way to
answer "which posts belong to this run_id?" when amortizing a stranded
`llm_research` row back to its siblings. Relying on the generation_log
post_id column is circular: if the pipeline died before amortize_research
ran, we'd trust the same table we're trying to repair.
- `Publisher::build_meta()` now accepts `?string $run_id` and writes
`_prautoblogger_run_id => $run_id` when non-empty. Null/empty preserves
existing null-safe legacy behaviour.
- `Publisher::create_post()` forwards the $run_id it already receives
into build_meta — one-line plumbing, no new parameters at call sites.
- `Activator::backpopulate_run_id_meta_v081()` runs once per site,
gated by `prautoblogger_migrated_run_id_meta_v081` option. Walks
`wp_prautoblogger_generation_log`, pairs (post_id, min(run_id)),
writes `_prautoblogger_run_id` on any post that doesn't already have
it. Uses `metadata_exists()` so it's a no-op on re-run.
- Activator also schedules the new daily `prautoblogger_reap_orphan_research_rows`
cron at 03:15 — 15 min after the primary generation cron — so live
pipelines have time to finish amortizing cleanly before the reaper scans.
- Deactivator unschedules the new hook alongside the existing cron hooks.
No user-visible behaviour change yet. The reaper handler ships in the
next commit; this one just ensures it will have the data + schedule it
needs when it lands.
Part of the v0.8.1 bundle (thread research-cost-reaper).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(cost): daily reaper for orphan llm_research rows
Implements the orphan-research-row reaper per thread research-cost-reaper
seq 1. When a pipeline dies between post creation and
`Post_Assembler::amortize_research_costs()` (Hostinger exec kill, OOM,
LiteSpeed cut, fatal), the shared research row stays in
`wp_prautoblogger_generation_log` with `post_id = NULL` and sibling
articles' cost popovers understate their true spend.
New class `PRAutoBlogger_Research_Reaper` owns:
- `on_cron()` — WP-Cron entrypoint hooked to the daily
`prautoblogger_reap_orphan_research_rows` event (already scheduled
by the Activator in the previous commit at 03:15).
- `reap()` — returns a `{reaped, deleted, skipped}` summary. For each
orphan `llm_research` row older than 1 hour (grace window for live
pipelines):
- `_prautoblogger_run_id` post_meta primary lookup.
- Falls back to distinct post_ids in gen_log with the same run_id.
- If ≥1 post found → delegate to the existing idempotent
`Post_Assembler::amortize_research_costs()`. That method inserts
the per-article rows and deletes the original orphan in one pass,
so the reaper is idempotent on re-run.
- If 0 posts found AND orphan is >7 days old → delete outright as
sunk cost with nothing to attribute to.
- Else → skip; try again the next day.
- Never throws. DB errors caught and logged WARNING.
New WP-CLI command `wp prautoblogger reap-research` registered in the
main loader when `WP_CLI` is defined — manual ops trigger that prints
the same summary.
Departure from the CTO's spec: the reap logic lives on
`Research_Reaper` instead of `Post_Assembler`. Placing it on
Post_Assembler pushed that file to 391 lines, over the 300-line cap.
Moving it to the thin class colocates the attribution logic with the
cron/CLI plumbing that triggers it. `amortize_research_costs()` stays
on Post_Assembler — the reaper delegates to it unchanged. Flagged for
CTO review.
Part of the v0.8.1 bundle (thread research-cost-reaper).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(cost): ResearchReaperTest — five cases per spec
Covers the five scenarios from convo thread research-cost-reaper seq 1:
- test_reaps_orphan_with_matching_run_id_posts — meta lookup returns
two post IDs; reaper delegates to amortize_research_costs which
inserts two rows and deletes the orphan.
- test_skips_orphan_within_grace_period — the SELECT's
`created_at < now - 1h` clause filters fresh orphans at the DB; the
reaper's stats stay zero and no side effects fire.
- test_deletes_orphan_with_no_articles_after_7_days — orphan is 8 days
old, zero siblings via meta or gen_log; reaper deletes outright.
- test_falls_back_to_gen_log_when_post_meta_missing — meta returns
empty (legacy pre-v0.8.1 post); gen_log has two distinct post_ids;
amortize still runs.
- test_idempotent_on_repeat_run — second pass on a cleaned state
returns 0/0/0 with no inserts or deletes.
All DB interaction mocked via $wpdb stub — no real DB round-trips.
Fixtures are driven by property mutations in the test methods so
PHPUnit's "one stub per method" restriction on mocks doesn't bite.
Part of the v0.8.1 bundle.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(v0.8.1): version bump + CHANGELOG + ARCHITECTURE.md for reaper
Bump plugin header and PRAUTOBLOGGER_VERSION 0.8.0 → 0.8.1. Patch
bump — the reaper is internal infrastructure; no user-visible UX
change.
CHANGELOG:
- Fixed: orphan `llm_research` rows now reaped daily.
- Added: WP-CLI `wp prautoblogger reap-research`; `_prautoblogger_run_id`
post_meta is now written by Publisher on every post.
ARCHITECTURE.md:
- Decision #13 (Run-ID based log linking) cross-refs the new post_meta.
- New Decision #19 documents the reaper's scan/amortize/delete policy,
the 1-hour grace window, the 7-day stale cutoff, and the one-shot
activator back-populate migration.
DB schema unchanged — no PRAUTOBLOGGER_DB_VERSION bump.
Final commit of the v0.8.1 bundle.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(cost): widen $wpdb mock so ResearchReaperTest actually runs
BaseTestCase::create_mock_wpdb() only adds methods
[prepare, get_var, get_results, insert, query, get_row, update] — the
reaper and amortize_research_costs also call `delete` and `get_col`,
which the default mock can't stub. CI on PR #100 fired all five new
ResearchReaperTest cases as errors at the first `->method('delete')`
call during setUp.
Fix: build a bespoke $wpdb mock in this file's setUp with the full
superset of methods it needs. Self-contained; no change to
BaseTestCase so existing tests aren't affected.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(cost): filter gen_log inserts from event_log inserts in reaper tests
CI on ec1efee showed the two reap-and-amortize tests failing because
`assertCount(2, $this->inserted_rows)` was seeing 4 rows, not 2. Root
cause: the Logger singleton writes INFO lines via `$wpdb->insert` into
the event_log table — the reaper logs once ("Reaped...") and amortize
logs once ("Amortized LLM research cost...") before the two per-post
gen_log inserts, so the capture ended up with 4 total rows.
Add a `gen_log_inserts()` helper that filters the capture down to rows
whose `__table` contains "generation_log" — the assertions on
attribution count should only measure the actual cost inserts, not
incidental log writes. Two tests updated; logic unchanged.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(admin): correct misleading GA4 Property ID description
The GA4 client at includes/core/class-ga4-client.php:85 already wraps the
property_id option with "properties/" in the outbound URL path. The admin
description told users to enter "properties/XXXXXXXXX" — which would have
produced a double-prefixed URL (properties/properties/XXXXXXXXX) and a
guaranteed 404 from the Data API. Description now asks for digits only,
matching actual code behavior.
No code logic change — UX copy + CHANGELOG only. Flagged by CEO while
inspecting the Analytics tab; folded into the in-flight v0.8.1 PR per
CTO call rather than cutting a separate patch.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: peptiderepo <peptiderepo@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
184 lines
6.3 KiB
PHP
184 lines
6.3 KiB
PHP
<?php
|
|
declare(strict_types=1);
|
|
|
|
/**
|
|
* Daily cron that retroactively amortizes orphan `llm_research` rows.
|
|
*
|
|
* When a pipeline run dies between post creation and the final
|
|
* `Post_Assembler::amortize_research_costs()` call (Hostinger exec kill,
|
|
* OOM, LiteSpeed cut, fatal), the shared research-cost row stays in
|
|
* `wp_prautoblogger_generation_log` with `post_id = NULL` and the
|
|
* articles from that run understate their true cost in the popover.
|
|
*
|
|
* This reaper scans for such orphan rows once a day, finds their sibling
|
|
* posts via the `_prautoblogger_run_id` post_meta (primary) or the
|
|
* gen_log's own post-linked rows (fallback for legacy posts that
|
|
* predate the meta), and delegates to the existing idempotent
|
|
* `amortize_research_costs()` method. Orphans that still have no
|
|
* siblings after 7 days are deleted outright as sunk cost.
|
|
*
|
|
* Spec-wise the CTO asked for the reap method to live on Post_Assembler;
|
|
* hosting it here instead keeps Post_Assembler under the 300-line cap
|
|
* (it grew past 300 with the reap method attached) and colocates the
|
|
* attribution logic next to the cron/CLI plumbing that triggers it.
|
|
*
|
|
* Triggered by:
|
|
* - WP-Cron: `prautoblogger_reap_orphan_research_rows` (daily, 03:15).
|
|
* - WP-CLI: `wp prautoblogger reap-research` (manual ops trigger).
|
|
* Dependencies: PRAutoBlogger_Post_Assembler (amortize_research_costs),
|
|
* PRAutoBlogger_Logger, WordPress $wpdb + get_posts.
|
|
*
|
|
* @see core/class-post-assembler.php — amortize_research_costs() does the work.
|
|
* @see class-activator.php — Schedules the daily cron.
|
|
* @see class-deactivator.php — Unschedules on deactivate.
|
|
* @see ARCHITECTURE.md — Cost tracking data flow.
|
|
*/
|
|
class PRAutoBlogger_Research_Reaper {
|
|
|
|
/** Grace window — live pipelines have this long to finish amortizing before reaping. */
|
|
private const GRACE_WINDOW_SECONDS = 3600; // 1 hour.
|
|
|
|
/** Stale window — orphans with no sibling posts are deleted outright after this long. */
|
|
private const STALE_WINDOW_SECONDS = 7 * 86400; // 7 days.
|
|
|
|
/**
|
|
* Cron action handler — entrypoint for the daily WP-Cron event.
|
|
*
|
|
* Pure delegate. Never throws.
|
|
*
|
|
* @return void
|
|
*/
|
|
public static function on_cron(): void {
|
|
self::reap();
|
|
}
|
|
|
|
/**
|
|
* Scan and reap orphan `llm_research` rows. Returns a summary that the
|
|
* WP-CLI command prints and the cron path ignores.
|
|
*
|
|
* Side effects: SELECT / INSERT / DELETE on generation_log; post_meta
|
|
* reads; one INFO log line per reaped or stale-deleted
|
|
* orphan; one WARNING on DB error.
|
|
*
|
|
* @return array{reaped: int, deleted: int, skipped: int}
|
|
*/
|
|
public static function reap(): array {
|
|
$stats = [ 'reaped' => 0, 'deleted' => 0, 'skipped' => 0 ];
|
|
|
|
try {
|
|
global $wpdb;
|
|
$log_table = $wpdb->prefix . 'prautoblogger_generation_log';
|
|
$grace = gmdate( 'Y-m-d H:i:s', time() - self::GRACE_WINDOW_SECONDS );
|
|
|
|
// phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery
|
|
$orphans = $wpdb->get_results(
|
|
$wpdb->prepare(
|
|
"SELECT id, run_id, created_at FROM {$log_table}
|
|
WHERE stage = 'llm_research' AND post_id IS NULL AND created_at < %s",
|
|
$grace
|
|
)
|
|
);
|
|
if ( ! is_array( $orphans ) ) {
|
|
return $stats;
|
|
}
|
|
|
|
$stale_cutoff = time() - self::STALE_WINDOW_SECONDS;
|
|
foreach ( $orphans as $orphan ) {
|
|
self::handle_orphan( $orphan, $stale_cutoff, $log_table, $stats );
|
|
}
|
|
} catch ( \Throwable $e ) {
|
|
PRAutoBlogger_Logger::instance()->warning(
|
|
'Reaper encountered DB error: ' . $e->getMessage(),
|
|
'cost-tracker'
|
|
);
|
|
}
|
|
|
|
return $stats;
|
|
}
|
|
|
|
/**
|
|
* Route one orphan row: amortize if siblings exist, delete if stale,
|
|
* otherwise skip and try again next run.
|
|
*
|
|
* @param object $orphan DB row with id, run_id, created_at.
|
|
* @param int $stale_cutoff Unix timestamp — orphans older than this delete.
|
|
* @param string $log_table Fully-qualified gen_log table name.
|
|
* @param array $stats Counters, mutated by reference.
|
|
* @return void
|
|
*/
|
|
private static function handle_orphan( object $orphan, int $stale_cutoff, string $log_table, array &$stats ): void {
|
|
global $wpdb;
|
|
$run_id = (string) ( $orphan->run_id ?? '' );
|
|
$created_ts = strtotime( (string) ( $orphan->created_at ?? '' ) );
|
|
$is_stale = false !== $created_ts && $created_ts < $stale_cutoff;
|
|
|
|
if ( '' === $run_id ) {
|
|
if ( $is_stale ) {
|
|
// phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery
|
|
$wpdb->delete( $log_table, [ 'id' => (int) $orphan->id ] );
|
|
$stats['deleted']++;
|
|
} else {
|
|
$stats['skipped']++;
|
|
}
|
|
return;
|
|
}
|
|
|
|
$post_ids = self::find_posts_for_run_id( $run_id );
|
|
if ( count( $post_ids ) >= 1 ) {
|
|
PRAutoBlogger_Post_Assembler::amortize_research_costs( $run_id );
|
|
PRAutoBlogger_Logger::instance()->info(
|
|
sprintf( 'Reaped research cost across %d articles for run %s.', count( $post_ids ), $run_id ),
|
|
'cost-tracker'
|
|
);
|
|
$stats['reaped']++;
|
|
return;
|
|
}
|
|
|
|
if ( $is_stale ) {
|
|
// phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery
|
|
$wpdb->delete( $log_table, [ 'id' => (int) $orphan->id ] );
|
|
PRAutoBlogger_Logger::instance()->info(
|
|
sprintf( 'Deleted 7-day-stale orphan research row for run %s — no articles to attribute.', $run_id ),
|
|
'cost-tracker'
|
|
);
|
|
$stats['deleted']++;
|
|
return;
|
|
}
|
|
|
|
$stats['skipped']++;
|
|
}
|
|
|
|
/**
|
|
* Return distinct post IDs for a given run_id. Prefers post_meta;
|
|
* falls back to gen_log rows for legacy posts.
|
|
*
|
|
* @param string $run_id Pipeline run UUID.
|
|
* @return int[] Distinct post IDs.
|
|
*/
|
|
private static function find_posts_for_run_id( string $run_id ): array {
|
|
$meta_ids = get_posts( [
|
|
'post_type' => 'any',
|
|
'post_status' => 'any',
|
|
'meta_key' => '_prautoblogger_run_id',
|
|
'meta_value' => $run_id,
|
|
'fields' => 'ids',
|
|
'posts_per_page' => -1,
|
|
'suppress_filters' => true,
|
|
] );
|
|
if ( is_array( $meta_ids ) && ! empty( $meta_ids ) ) {
|
|
return array_map( 'intval', $meta_ids );
|
|
}
|
|
|
|
global $wpdb;
|
|
$log_table = $wpdb->prefix . 'prautoblogger_generation_log';
|
|
// phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery
|
|
$ids = $wpdb->get_col(
|
|
$wpdb->prepare(
|
|
"SELECT DISTINCT post_id FROM {$log_table} WHERE run_id = %s AND post_id IS NOT NULL",
|
|
$run_id
|
|
)
|
|
);
|
|
return is_array( $ids ) ? array_map( 'intval', $ids ) : [];
|
|
}
|
|
}
|