ci(deploy): promote smoke to a production gate (#10)

deploy-production now needs smoke; a smoke FAILURE blocks prod while a skipped
smoke (run_smoke:false) still allows it. Automated functional gate replacing
the removed human approval gate — hands-off but safe.

Agent-Session: cto gate-smoke

Co-authored-by: peptiderepo <peptiderepo@users.noreply.github.com>

.github/workflows/deploy-app.yml

@@ -79,7 +79,10 @@ jobs:
 
   deploy-production:
     name: Deploy to Production
-    needs: [deploy-staging]
+    # Smoke is now a GATE: a smoke FAILURE blocks production. A deliberately
+    # skipped smoke (run_smoke: false) still allows prod via the if-condition.
+    needs: [deploy-staging, smoke]
+    if: ${{ !cancelled() && needs.deploy-staging.result == 'success' && needs.smoke.result != 'failure' }}
     runs-on: ubuntu-latest
     environment: production
     steps: