peptide-repo/peptide-e2e
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

ci(smoke): add comment explaining why --with-deps is omitted #24

Merged
peptiderepo merged 1 commits from claude/smoke-no-withdeps-20260617 into main 2026-06-17 05:12:50 +00:00
Conversation 0 Commits 1 Files Changed 1 +1
peptiderepo commented 2026-06-17 05:10:39 +00:00 (Migrated from github.com)
Copy Link

What changed

Adds an inline YAML comment to the Install Playwright browsers step in smoke.yml:

# OS deps pre-installed on the self-hosted runner host; --with-deps needs sudo which the sandbox blocks
run: npx playwright install chromium

Why

The --with-deps flag was dropped in commit e00f777 (PR #23) because the ghrunner sandbox on peptide-vps runs with NoNewPrivileges=yes, which blocks the apt-get calls that --with-deps triggers. That commit dropped the flag but left no comment explaining the omission. Future maintainers seeing a bare npx playwright install chromium might add --with-deps back assuming it is a mistake. This comment closes that gap.

Risk flags

None — zero functional change. Comment only.

Test plan

  • YAML validated via python3 yaml.safe_load: VALID
  • git diff confirms exactly 1 line inserted, no other changes
  • actionlint/yamllint not available on the CI sandbox; Python parse sufficient for a comment-only change

Do NOT merge — awaiting CTO review.

## What changed Adds an inline YAML comment to the `Install Playwright browsers` step in `smoke.yml`: ```yaml # OS deps pre-installed on the self-hosted runner host; --with-deps needs sudo which the sandbox blocks run: npx playwright install chromium ``` ## Why The `--with-deps` flag was dropped in commit `e00f777` (PR #23) because the `ghrunner` sandbox on `peptide-vps` runs with `NoNewPrivileges=yes`, which blocks the `apt-get` calls that `--with-deps` triggers. That commit dropped the flag but left no comment explaining the omission. Future maintainers seeing a bare `npx playwright install chromium` might add `--with-deps` back assuming it is a mistake. This comment closes that gap. ## Risk flags None — zero functional change. Comment only. ## Test plan - YAML validated via `python3 yaml.safe_load`: VALID - `git diff` confirms exactly 1 line inserted, no other changes - actionlint/yamllint not available on the CI sandbox; Python parse sufficient for a comment-only change **Do NOT merge** — awaiting CTO review.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 deploy-health
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
admin
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: peptide-repo/peptide-e2e#24
Delete Branch "claude/smoke-no-withdeps-20260617"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?