Compare commits

..

1 Commits

Author SHA1 Message Date
peptiderepo
8472667418 ci(review): drop panel to Haiku-only per QA A/B decision 2026-06-12
A/B analysis across 13 PRs (convo/cto/threads/2026-06-qa-ab-review/02-analyst-findings.md):
- DeepSeek: high false-positive rate (absint()="code exec", PLUGIN_DIR="dir traversal")
- Kimi: ~60% model failure rate, 1 unique-real finding in 13 PRs
- Neurometric: summarizer only, 0 unique-real findings, unreliable heuristic verdict label
- Haiku: 0 failures, lowest noise, equivalent real-signal catch vs 4-voice panel

Removes DeepSeek, Kimi, and Neurometric voices. Haiku is now sole reviewer.
Also removes NEUROMETRIC_API_KEY env var (no longer needed).
No plugin version bump -- CI-only change (precedent: prautoblogger #150).

Agent-Session: engineer-panel-haiku-20260612
2026-06-12 14:25:50 +00:00
16 changed files with 151 additions and 140 deletions

View File

@@ -1,27 +1,134 @@
##
# Thin CI caller — peptide-news-plugin
#
# Delegates all lint/test/file-size jobs to the estate reusable workflow.
# Per estate standard: workflow_call is required so deploy.yml can gate on it.
# See: peptide-repo/peptide-e2e/.github/workflows/ci.yml@main for job definitions.
##
name: CI
name: CI — Lint & Test
on:
pull_request: {}
push:
branches: [main]
workflow_call: {}
branches: [ main ]
pull_request:
branches: [ main ]
workflow_call:
# Required: calling workflow must declare contents: write so the reusable
# phpcs job can commit phpcbf auto-fixes back to the PR branch.
permissions:
contents: write
contents: read
jobs:
ci:
uses: peptide-repo/peptide-e2e/.github/workflows/ci.yml@main
with:
tests: stubs
has_js: true
secrets: inherit
# ── PHP Syntax Check ─────────────────────────────────────────────
lint-php:
name: PHP Lint (${{ matrix.php }})
runs-on: ubuntu-latest
strategy:
matrix:
php: ['8.1', '8.2', '8.3']
steps:
- uses: actions/checkout@v4
- name: Set up PHP ${{ matrix.php }}
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
tools: composer
- name: Syntax check all PHP files
run: find . -name '*.php' -not -path './vendor/*' -print0 | xargs -0 -n1 php -l
# ── Security Audit ───────────────────────────────────────────────
security-audit:
name: Security Audit
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check for common PHP security issues
run: |
echo ":: Checking for direct SQL queries without prepare..."
# Exclude uninstall.php (DROP TABLE is standard WP pattern), activator (table DDL),
# and logger (TRUNCATE) — these use $wpdb->prefix which is safe internal state.
if grep -r "query\s*(\s*['\"].*\$" --include="*.php" --exclude-dir=vendor . 2>/dev/null \
| grep -v "\\\$wpdb->prepare" \
| grep -v "uninstall\.php" \
| grep -v "class-peptide-news-activator\.php" \
| grep -v "class-peptide-news-logger\.php" \
| grep -v "DROP TABLE" \
| grep -v "TRUNCATE" \
&& [ \${PIPESTATUS[0]} -eq 0 ]; then
echo "WARNING: Found potential unescaped SQL queries. Use wpdb->prepare() for all dynamic SQL."
exit 1
fi
echo ":: Checking for eval() usage..."
if grep -r "eval\s*(" --include="*.php" --exclude-dir=vendor . 2>/dev/null; then
echo "ERROR: eval() found. This is a critical security risk."
exit 1
fi
echo ":: Checking for base64_decode without validation..."
if grep -r "base64_decode\s*(" --include="*.php" --exclude-dir=vendor . 2>/dev/null; then
echo "WARNING: Found base64_decode(). Ensure the input is properly validated."
fi
echo ":: Checking for file_get_contents with user input..."
if grep -r "file_get_contents\s*(\s*\$" --include="*.php" --exclude-dir=vendor . 2>/dev/null; then
echo "WARNING: Found file_get_contents with variable. Ensure input is validated and restricted."
fi
echo "All security checks passed."
# ── PHPCS Coding Standards ───────────────────────────────────────
phpcs:
name: PHPCS
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.3'
tools: composer
- name: Install dependencies
run: composer install --prefer-dist --no-progress
- name: Run PHPCS
run: vendor/bin/phpcs --standard=.phpcs.xml.dist
continue-on-error: true
# ── PHPUnit Tests ────────────────────────────────────────────────
phpunit:
name: PHPUnit (${{ matrix.php }})
runs-on: ubuntu-latest
strategy:
matrix:
php: ['8.1', '8.2', '8.3']
steps:
- uses: actions/checkout@v4
- name: Set up PHP ${{ matrix.php }}
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
tools: composer
coverage: xdebug
- name: Install dependencies
run: composer install --prefer-dist --no-progress
- name: Run PHPUnit
run: vendor/bin/phpunit --testdox
# ── JavaScript Lint ──────────────────────────────────────────────
lint-js:
name: JS Lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up Node
uses: actions/setup-node@v4
with:
node-version: '20'
- name: Check JS syntax
run: |
for f in $(find . -name '*.js' -not -path './vendor/*' -not -path './node_modules/*' -not -path '*/vendor/*'); do
node --check "$f" || exit 1
done

View File

@@ -4,12 +4,8 @@ on:
push:
branches: [ main ]
# contents: write required so the ci.yml caller can pass write permission
# through to the phpcbf auto-commit step in the reusable workflow.
# (phpcbf commit only fires on pull_request events, but GH enforces caller
# permissions at token-grant time, not at step-execution time.)
permissions:
contents: write
contents: read
concurrency:
group: deploy-peptide-news-plugin
@@ -23,7 +19,7 @@ jobs:
deploy:
name: Deploy (shared pipeline)
needs: test
uses: peptide-repo/peptide-e2e/.github/workflows/deploy-app.yml@main
uses: peptiderepo/peptide-e2e/.github/workflows/deploy-app.yml@main
with:
target_path: wp-content/plugins/peptide-news-plugin
secrets: inherit

View File

@@ -1,58 +0,0 @@
##
# Security audit — peptide-news-plugin
#
# Standalone workflow kept separate from the estate CI caller so it can evolve
# independently and run on every PR without being bundled into the reusable pipeline.
# Checks for: unescaped SQL, eval(), base64_decode(), file_get_contents with user input.
##
name: Security Audit
on:
pull_request: {}
push:
branches: [main]
permissions:
contents: read
jobs:
security-audit:
name: Security Audit
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check for common PHP security issues
run: |
echo ":: Checking for direct SQL queries without prepare..."
# Exclude uninstall.php (DROP TABLE is standard WP pattern), activator (table DDL),
# and logger (TRUNCATE) — these use $wpdb->prefix which is safe internal state.
if grep -r "query\s*(\s*['\"].*\$" --include="*.php" --exclude-dir=vendor . 2>/dev/null \
| grep -v "\$wpdb->prepare" \
| grep -v "uninstall\.php" \
| grep -v "class-peptide-news-activator\.php" \
| grep -v "class-peptide-news-logger\.php" \
| grep -v "DROP TABLE" \
| grep -v "TRUNCATE" \
&& [ ${PIPESTATUS[0]} -eq 0 ]; then
echo "WARNING: Found potential unescaped SQL queries. Use wpdb->prepare() for all dynamic SQL."
exit 1
fi
echo ":: Checking for eval() usage..."
if grep -r "eval\s*(" --include="*.php" --exclude-dir=vendor . 2>/dev/null; then
echo "ERROR: eval() found. This is a critical security risk."
exit 1
fi
echo ":: Checking for base64_decode without validation..."
if grep -r "base64_decode\s*(" --include="*.php" --exclude-dir=vendor . 2>/dev/null; then
echo "WARNING: Found base64_decode(). Ensure the input is properly validated."
fi
echo ":: Checking for file_get_contents with user input..."
if grep -r "file_get_contents\s*(\s*\$" --include="*.php" --exclude-dir=vendor . 2>/dev/null; then
echo "WARNING: Found file_get_contents with variable. Ensure input is validated and restricted."
fi
echo "All security checks passed."

View File

@@ -73,13 +73,9 @@
<type>warning</type>
</rule>
<!--
PHPCompatibilityWP removed: the estate CI reusable workflow installs
only wp-coding-standards/wpcs + phpcsutils + phpcsextra via global
composer require. phpcompatibility/phpcompatibility-wp is not available
in that environment. PHP version targeting is covered by the lint-php
matrix job (8.1 / 8.2 / 8.3 syntax check).
-->
<!-- PHP Compatibility — target PHP 7.4+ -->
<config name="testVersion" value="7.4-"/>
<rule ref="PHPCompatibilityWP"/>
<!-- Allow long lines in SQL queries up to 200 chars -->
<rule ref="Generic.Files.LineLength">

View File

@@ -1,30 +0,0 @@
# Changelog
All notable changes to Peptide News Plugin are documented here.
Format: [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
Versioning: [Semantic Versioning](https://semver.org/).
## [2.5.0] — 2026-06-16
### Changed
- **CI standardization (estate wave 2):** Replace per-repo CI jobs in
`ci.yml` with a thin caller of `peptiderepo/peptide-e2e/.github/workflows/ci.yml@main`
(`tests: stubs`, `has_js: true`). Adds `workflow_call` trigger so `deploy.yml`
gate remains valid.
- Extract `security-audit` job from `ci.yml` into standalone
`.github/workflows/security-audit.yml` (kept as-is, unique to this repo).
- `deploy.yml`: elevate permissions to `contents: write` so the nested
phpcbf commit-back step in the reusable workflow receives the correct token scope.
- `composer.json`: pin `test` script to `vendor/bin/phpunit --configuration phpunit.xml.dist`
for explicit path resolution in CI; pin `lint` / `lint:fix` to `vendor/bin/`.
- `phpunit.xml.dist`: add XSD reference for PHPUnit 9.6; drop deprecated
`convertErrorsToExceptions`, `convertNoticesToExceptions`, `convertWarningsToExceptions`
attributes.
### Notes
- `rollback.yml` and `cto-review.yml` and `main-push-audit.yml` unchanged — unique / estate-separate.
- No functional code changes in this commit.
## Prior history
Versions prior to 2.5.0 were not tracked in a CHANGELOG. See git log for details.

View File

@@ -21,9 +21,9 @@
}
},
"scripts": {
"test": "vendor/bin/phpunit --configuration phpunit.xml.dist",
"lint": "vendor/bin/phpcs",
"lint:fix": "vendor/bin/phpcbf",
"test": "phpunit",
"lint": "phpcs",
"lint:fix": "phpcbf",
"check": [
"@lint",
"@test"

View File

@@ -107,7 +107,7 @@ class Peptide_News_Content_Filter_Rules {
continue;
}
if ( false !== strpos( $body_text, $keyword ) ) {
++$body_matches;
$body_matches++;
$matched_keys[] = $keyword;
$score += 15;
}

View File

@@ -79,7 +79,7 @@ class Peptide_News_Content_Filter {
);
if ( 'promotional' === $result['verdict'] ) {
++$removed;
$removed++;
self::log( sprintf( 'Blocked (rule: %s, score: %d): %s', $result['rule'], $result['score'], $article['title'] ) );
continue;
}
@@ -87,10 +87,10 @@ class Peptide_News_Content_Filter {
// Borderline articles go to LLM for a second opinion.
if ( 'borderline' === $result['verdict'] && self::is_llm_filter_enabled() ) {
$llm_verdict = self::classify_with_llm( $article );
++$llm_checked;
$llm_checked++;
if ( 'promotional' === $llm_verdict ) {
++$removed;
$removed++;
self::log( sprintf( 'Blocked (LLM confirmed borderline): %s', $article['title'] ) );
continue;
}

View File

@@ -87,7 +87,7 @@ class Peptide_News_Fetcher {
$stored = 0;
foreach ( $articles as $article ) {
if ( $this->store_article( $article ) ) {
++$stored;
$stored++;
}
}

View File

@@ -137,7 +137,7 @@ class Peptide_News_LLM_Client {
$retry_after = wp_remote_retrieve_header( $response, 'retry-after' );
$wait = $retry_after ? min( (int) $retry_after, 30 ) : $backoff;
sleep( $wait );
++$retries;
$retries++;
$backoff *= 2;
continue;
}

View File

@@ -183,7 +183,7 @@ class Peptide_News_LLM {
$result = self::process_article( $article );
if ( ! empty( $result['success'] ) ) {
++$processed;
$processed++;
}
if ( ! empty( $result['errors'] ) ) {
$last_errors = $result['errors'];

View File

@@ -104,7 +104,6 @@ class Peptide_News_Rest_API {
if ( ! preg_match( '/^\\d{4}-\\d{2}-\\d{2}$/', $value ) ) {
return new WP_Error(
'rest_invalid_date',
/* translators: %s: REST API parameter name */
sprintf( __( 'Invalid date format for %s. Expected Y-m-d.', 'peptide-news' ), $param ),
array( 'status' => 400 )
);

View File

@@ -126,7 +126,7 @@ class Peptide_News_Source_Resolver {
if ( ! empty( $new_source ) && $new_source !== $article->source ) {
$wpdb->update( $table, array( 'source' => $new_source ), array( 'id' => $article->id ), array( '%s' ), array( '%d' ) );
++$updated;
$updated++;
}
}

View File

@@ -3,7 +3,7 @@
* Plugin Name: Peptide News Aggregator
* Plugin URI: https://github.com/peptiderepo/peptide-news-plugin
* Description: Aggregates and displays the latest peptide research news from multiple sources with click analytics and trend reporting.
* Version: 2.5.0
* Version: 2.4.1
* Author: peptiderepo
* Author URI: https://github.com/peptiderepo
* License: GPL-2.0+
@@ -24,7 +24,7 @@ if ( ! defined( 'WPINC' ) ) {
/**
* Current plugin version — follows SemVer.
*/
define( 'PEPTIDE_NEWS_VERSION', '2.5.0' );
define( 'PEPTIDE_NEWS_VERSION', '2.4.0' );
define( 'PEPTIDE_NEWS_PLUGIN_DIR', plugin_dir_path( __FILE__ ) );
define( 'PEPTIDE_NEWS_PLUGIN_URL', plugin_dir_url( __FILE__ ) );
define( 'PEPTIDE_NEWS_PLUGIN_BASENAME', plugin_basename( __FILE__ ) );

View File

@@ -1,10 +1,11 @@
<?xml version="1.0"?>
<phpunit
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.6/phpunit.xsd"
bootstrap="tests/bootstrap.php"
backupGlobals="false"
colors="true"
convertErrorsToExceptions="true"
convertNoticesToExceptions="true"
convertWarningsToExceptions="true"
>
<testsuites>
<testsuite name="unit">

View File

@@ -2,7 +2,7 @@
declare( strict_types=1 );
if ( ! defined( 'WP_UNINSTALL_PLUGIN' ) ) {
exit;
exit;
}
global $wpdb;
$prefix = $wpdb->prefix;
@@ -16,12 +16,12 @@ $wpdb->query( "DROP TABLE IF EXISTS {$prefix}peptide_news_articles" );
// Delete all plugin options.
$wpdb->query(
"DELETE FROM {$wpdb->options} WHERE option_name LIKE 'peptide\_news\_%'"
"DELETE FROM {$wpdb->options} WHERE option_name LIKE 'peptide\_news\_%'"
);
// Remove transient caches.
$wpdb->query(
"DELETE FROM {$wpdb->options} WHERE option_name LIKE '_transient_peptide\_news\_%' OR option_name LIKE '_transient_timeout_peptide\_news\_%'"
"DELETE FROM {$wpdb->options} WHERE option_name LIKE '_transient_peptide\_news\_%' OR option_name LIKE '_transient_timeout_peptide\_news\_%'"
);
// Clear scheduled events.