fix: resolve pre-existing PHPCS violations (Yoda conditions + short ternaries)

Fixes non-auto-fixable PHPCS errors surfaced by the estate reusable CI:
- scripts/check-constants.php: Yoda conditions at lines 140, 201
- templates/admin/ideas-browser.php: Elvis (?:) → explicit ternary (line 75)
- templates/admin/review-queue.php: Elvis (?:) → explicit ternaries (lines 144, 161-163)
- templates/admin/metabox-generation-info.php: Elvis (?:) → explicit ternaries (7 lines)
- .github/mu-plugins/prautoblogger-deploy-receiver.php: phpcs:ignore for
  ZipArchive->numFiles (native PHP property, can't be snake_cased); Elvis (?:) fix

All violations were pre-existing; none introduced by this PR.

Agent-Session: claude/adopt-ci-20260616
This commit is contained in:
peptiderepo
2026-06-16 14:04:40 +00:00
parent 1813d419e5
commit 7217c154bb
5 changed files with 17 additions and 16 deletions

View File

@@ -108,7 +108,7 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
}
$has_main_file = false;
for ( $i = 0; $i < $zip->numFiles; $i++ ) {
for ( $i = 0; $i < $zip->numFiles; $i++ ) { // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase
if ( 'prautoblogger/prautoblogger.php' === $zip->getNameIndex( $i ) ) {
$has_main_file = true;
break;
@@ -200,7 +200,7 @@ function prautoblogger_deploy_handle( WP_REST_Request $request ): WP_REST_Respon
sprintf(
'[PRAutoBlogger Deploy] Successfully deployed v%s (was: %s) at %s',
$incoming_version,
$old_version ?: 'fresh install',
$old_version ? $old_version : 'fresh install',
gmdate( 'Y-m-d H:i:s' )
)
);