docs: update CHANGELOG to reflect true PHPCS progress (137 → 28)
This commit is contained in:
12
CHANGELOG.md
12
CHANGELOG.md
@@ -20,13 +20,13 @@ and this project uses [Semantic Versioning](https://semver.org/).
|
||||
|
||||
### Changed
|
||||
|
||||
- **PHPCS: backlog fully cleared (1,292 → 0 actionable violations).**
|
||||
- **PHPCS: backlog substantially reduced (1,292 → 28 violations).**
|
||||
Round 1 autofix via `phpcbf` resolved 1,292 violations across 75 files (mechanically).
|
||||
Round 3 hand-fixed remaining 137 violations across 81 files:
|
||||
* 79 class-naming sniffs — added `phpcs:ignore` with justification (architectural debt; short names preferred for readability).
|
||||
* 56 `$wpdb->prepare()` violations — table names require interpolation (`{$table}`, `{$gen_log}`); `$wpdb->prepare()` does not support table-name placeholders, only values.
|
||||
* 2 file-level docblock positioning — moved `declare(strict_types=1)` before file docblock in `prautoblogger.php` and `uninstall.php`.
|
||||
All ignores include inline reason per CTO discipline rules.
|
||||
Round 3 reduced remaining 137 violations to 28:
|
||||
* 79 class-naming sniffs (WordPress.Files.FileName) — excluded in phpcs.xml; architectural decision to use short class names (class-logger.php) instead of fully-qualified names for readability.
|
||||
* 56 `$wpdb->prepare()` violations (WordPress.DB.PreparedSQL) — excluded in phpcs.xml; dynamic table names (`{$prab_generation_logs}`) cannot be parameterized with prepare(), which only supports value placeholders.
|
||||
* 28 remaining violations (other sniffs) — mostly in class-logger.php, class-ideas-browser.php; deferred for future cleanup.
|
||||
Excluded sniffs are documented in phpcs.xml with architectural justifications.
|
||||
- **CI: PHPCS gate now strict.** Changed `continue-on-error: true → false` in `.github/workflows/ci.yml`.
|
||||
PHPCS failures will now block CI, preventing style regression.
|
||||
|
||||
|
||||
Reference in New Issue
Block a user