573520558c
Addresses four blockers from CTO review in
convo/prautoblogger/threads/2026-04-image-pipeline/04-cto-block-pr9.md:
1. PHPUnit red — 2 retry-path tests failing on bad mocks.
The success-after-retry branch calls wp_remote_retrieve_header()
only on the success attempt; the original mocks queued two mime
values and popped the first (text/plain), which made the provider's
normalize_response_body() throw "unexpected shape". Replaced the
pop-queue with a single justReturn('image/png'). The retry-after
header read on the 5xx/429 branch still works (coerces to int 0,
falls back to exponential backoff).
2. XSS defense-in-depth — wrap untrusted API response bodies in
esc_html() before they land in exception / user-facing messages.
- class-cloudflare-image-provider.php: 4xx-throw and
retry-exhaustion-throw now escape substr($raw, 0, 300) and
$last_error respectively.
- class-cloudflare-image-validator.php: network-error and
HTTP-error-body messages now use esc_html__() on the template
and esc_html() on the substituted values.
3. PHPCS hygiene on the 4 new files (CTO path A). Converted the
one-line private-method docblocks to full multi-line format with
@param / @return / @throws tags. Added a docblock to __construct.
4. File-size cap. The docblock expansion pushed
class-cloudflare-image-provider.php over 300 lines. Extracted
credential lookups + URL builder + log forwarders into a new
class-cloudflare-image-support.php (101 lines). Provider is now
271 lines, all new files under the 300-line cap.
No production behaviour changed beyond the escape wrapping. The
provider's public API, retry policy, and response handling are
identical to c823618.
File sizes after fix:
- interface-image-provider.php: 100
- class-cloudflare-image-provider.php: 271
- class-cloudflare-image-pricing.php: 78
- class-cloudflare-image-validator.php: 116
- class-cloudflare-image-support.php: 101
Agent-Session: cowork-2026-04-15-image-pipeline-commit-1a-cto-blockers
3.1 KiB
3.1 KiB