P1: DossierMenuRegistrationTest.php was 551 lines (cap 300). Split into:
- DossierMenuRegistrationTestCase.php (120 lines): shared Brain\Monkey harness,
add_submenu_page spy stub, $submenu isolation — abstract base class.
- DossierMenuRegistrationTest.php (235 lines): structural invariants (parent slug,
$submenu non-mutation, page slug constant, asset enqueue gate prefix), deep-link
URL shape, and hook priority ordering — 7 test methods.
- DossierHooknameMechanismTest.php (198 lines): request-time hookname faithfulness
(simulate_request_time_hookname discriminator) and regression proof — 2 test methods.
Method inventory parity: 9 before = 9 after.
Before: test_request_time_hookname_matches_registration_hookname,
test_hide_by_unset_would_fail_request_time_check,
test_dossier_parent_slug_is_options_php, test_no_submenu_mutation_after_registration,
test_dossier_uses_correct_slug, test_asset_enqueue_gate_uses_admin_page_prefix,
test_url_for_post_contains_slug_and_post_id, test_url_for_post_exact_shape,
test_dossier_hook_registered_at_priority_12.
After: same 9, split 7/2 across two files. Zero assertions dropped.
P3: class-dossier-page.php docblock §22c → §22b (two occurrences).
No §22c heading exists in ARCHITECTURE.md; convention content is in §22b.
Agent-Session: dossier-403-hotfix-20260612
121 lines
3.6 KiB
PHP
121 lines
3.6 KiB
PHP
<?php
|
|
/**
|
|
* Shared test harness for Dossier menu registration test suites.
|
|
*
|
|
* Provides the Brain\Monkey spy stubs (add_menu_page, add_submenu_page) and the
|
|
* $submenu isolation that both DossierMenuRegistrationTest and
|
|
* DossierHooknameMechanismTest depend on.
|
|
*
|
|
* @package PRAutoBlogger\Tests\Admin
|
|
*/
|
|
|
|
namespace PRAutoBlogger\Tests\Admin;
|
|
|
|
use PRAutoBlogger\Tests\BaseTestCase;
|
|
use Brain\Monkey\Functions;
|
|
|
|
abstract class DossierMenuRegistrationTestCase extends BaseTestCase {
|
|
|
|
/** @var array<int, string> Call sequence spy. */
|
|
protected array $call_sequence = [];
|
|
|
|
/**
|
|
* Captured parent slug from the most recent add_submenu_page call.
|
|
*
|
|
* @var string|null
|
|
*/
|
|
protected ?string $captured_parent_slug = null;
|
|
|
|
/**
|
|
* Captured menu slug from the most recent add_submenu_page call.
|
|
*
|
|
* @var string|null
|
|
*/
|
|
protected ?string $captured_menu_slug = null;
|
|
|
|
/**
|
|
* Hookname returned by the most recent add_submenu_page call.
|
|
*
|
|
* In real WordPress this is `{parent_key}_page_{slug}` when parent is known,
|
|
* or `admin_page_{slug}` when parent is not in $admin_page_hooks. For options.php
|
|
* children WordPress always emits `admin_page_{slug}`.
|
|
*
|
|
* @var string|null
|
|
*/
|
|
protected ?string $registration_hookname = null;
|
|
|
|
protected function setUp(): void {
|
|
parent::setUp();
|
|
$this->call_sequence = [];
|
|
$this->captured_parent_slug = null;
|
|
$this->captured_menu_slug = null;
|
|
$this->registration_hookname = null;
|
|
|
|
// Spy stub: tracks call order, captures slugs, returns a hookname that
|
|
// reflects how WordPress actually resolves it for known parents.
|
|
Functions\when( 'add_menu_page' )->alias(
|
|
function () {
|
|
$this->call_sequence[] = 'add_menu_page';
|
|
return 'prautoblogger-settings';
|
|
}
|
|
);
|
|
|
|
// Simulate WordPress hookname computation:
|
|
// - options.php parent → 'admin_page_{slug}'
|
|
// - known plugin parent → '{parent_key}_page_{slug}'
|
|
// - unknown parent → 'admin_page_{slug}' (orphan fallback)
|
|
Functions\when( 'add_submenu_page' )->alias(
|
|
function (
|
|
string $parent_slug,
|
|
string $page_title,
|
|
string $menu_title,
|
|
string $capability,
|
|
string $menu_slug,
|
|
$callback = ''
|
|
) {
|
|
$this->call_sequence[] = 'add_submenu_page:' . $parent_slug . ':' . $menu_slug;
|
|
$this->captured_parent_slug = $parent_slug;
|
|
$this->captured_menu_slug = $menu_slug;
|
|
|
|
if ( 'options.php' === $parent_slug ) {
|
|
$hookname = 'admin_page_' . $menu_slug;
|
|
} else {
|
|
$parent_key = str_replace( '.php', '', $parent_slug );
|
|
$hookname = $parent_key . '_page_' . $menu_slug;
|
|
}
|
|
|
|
$this->registration_hookname = $hookname;
|
|
|
|
// Populate $submenu as WordPress does at registration time.
|
|
// phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited -- test simulation.
|
|
global $submenu;
|
|
$submenu[ $parent_slug ] = $submenu[ $parent_slug ] ?? array();
|
|
$submenu[ $parent_slug ][] = array( $page_title, $capability, $menu_slug, $menu_title );
|
|
|
|
return $hookname;
|
|
}
|
|
);
|
|
|
|
Functions\when( 'current_user_can' )->justReturn( true );
|
|
Functions\when( 'get_option' )->justReturn( false );
|
|
Functions\when( 'admin_url' )->alias(
|
|
function ( string $path = '' ) {
|
|
return 'https://example.com/wp-admin/' . ltrim( $path, '/' );
|
|
}
|
|
);
|
|
Functions\when( '__' )->returnArg( 1 );
|
|
|
|
// phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited -- test isolation.
|
|
$GLOBALS['submenu'] = array();
|
|
}
|
|
|
|
protected function tearDown(): void {
|
|
$this->call_sequence = [];
|
|
$this->captured_parent_slug = null;
|
|
$this->captured_menu_slug = null;
|
|
$this->registration_hookname = null;
|
|
unset( $GLOBALS['submenu'] );
|
|
parent::tearDown();
|
|
}
|
|
}
|