188e6603dd
* test(images): update ImagePromptBuilderTest for array-returning builder
`build_article_prompt()` and `build_source_prompt()` have returned
`array{prompt: string, caption: string}` since v0.4.x; five existing
tests still asserted against the envelope as if it were a string. On
PHP 8+ `assertStringContainsString` and `strlen()` raise a TypeError
when handed an array, so every one of those tests failed on the CI
matrix even though the production code is fine.
Fix is mechanical per CTO spec in convo seq 6: destructure the return
on receipt and assert against `$scene` / `$caption`. Cases updated:
- test_build_article_prompt_from_content
- test_build_article_prompt_with_missing_content
- test_build_source_prompt_from_reddit_data
- test_build_source_prompt_without_comments
- test_prompts_are_reasonably_sized (500-char cap now bound to the
scene+style-suffix, which is what the cap was always meant to measure)
No production code changes. Unrelated pre-existing failures
(`Call to undefined function post_type_exists()` in Publisher fixtures
and the repo-wide PHPCS backlog) remain out of scope per CTO.
Follow-up to PR #97 (v0.8.0 image bundle), which shipped before this
test fix landed. Context in convo thread image-mime-bug seq 07.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(images): drop unreachable content-based assertion in article-prompt test
Per CTO review on PR #99 (convo image-mime-bug seq 8): the earlier diff
destructured the return value correctly, but left an assertion for
'Dragons are fascinating' — a content substring. With no OpenRouter key
in the unit-test env, `rewrite_via_llm()` catches and falls back to
`synthesize_visual_concepts_fallback()`, which uses title only. The
content substring is structurally unreachable on that path, so the
assertion can never pass without mocking the LLM.
Picking CTO option 1 ("honest and minimal"): drop the content
assertion. The title + non-empty + length + caption-is-string checks
remain — those describe what the method actually guarantees regardless
of LLM reachability. Content-path testing belongs in a mocked-LLM test
(see `test_rewrite_uses_setting_when_present`, which already covers it).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: peptiderepo <peptiderepo@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
8.3 KiB
8.3 KiB