fb1451c4dc
Cloudflare's Workers AI FLUX.1 schnell content filter sometimes rejects peptide-comic prompts as NSFW (HTTP 400, errors[].code === 3030). On 2026-04-20 this produced a silent publish-without-featured-image for post #650 ("Semaglutide vs Tirzepatide") — the LLM-rewritten scene tripped the filter and we had no recovery path. New behaviour: on a 3030 response, the Cloudflare provider throws a typed PRAutoBlogger_Image_NSFW_Blocked exception. The batch wrapper catches it and tags the per-slot result with `error_type: nsfw_blocked`. Image_Pipeline hands the results to a new PRAutoBlogger_Image_NSFW_Retry helper, which reruns the blocked slot once with a sanitized fallback prompt (title + style suffix, no LLM rewrite). On success the retry result replaces the error entry; on a second block, a WARNING is logged and the pipeline publishes without that image — same terminal behaviour we had before, just explicit. Files: - New providers/class-image-nsfw-blocked.php — typed exception. - providers/class-cloudflare-image-support.php — is_nsfw_error() + throw_if_nsfw() helpers. - providers/class-cloudflare-image-provider.php — calls throw_if_nsfw inside the 4xx branch; batch catches the typed exception and marks the result with error_type. - core/class-image-prompt-builder.php — new public build_fallback_prompt shim so the retry layer can reach the rule-based fallback without going through the LLM path. - New core/class-image-nsfw-retry.php — single-shot retry helper. - core/class-image-pipeline.php — invokes the retry between batch completion and per-slot processing. - admin/class-settings-fields-extended.php — new toggle `prautoblogger_image_nsfw_retry` (default on) in the Images section. Tests: - CloudflareImageProviderTest — 3030 response throws NSFW exception; batch tags the per-slot result with `error_type: nsfw_blocked`. - ImagePipelineTest — retry succeeds when provider returns a good result on the second call; retry is skipped when the setting is off. Cost impact: worst-case an extra Cloudflare call per NSFW-blocked slot (~$0.000834). Current incidence ~2% of generations; ~+$0.00002 per generation amortized. Immaterial. Uninstall: new option covered by the existing prautoblogger_% LIKE sweep in uninstall.php. Part of the v0.8.0 image bundle (issues from thread image-mime-bug). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
391 lines
14 KiB
PHP
391 lines
14 KiB
PHP
<?php
|
||
/**
|
||
* Tests for PRAutoBlogger_Image_Pipeline.
|
||
*
|
||
* Validates image generation orchestration, including A/B generation,
|
||
* cost tracking, and graceful failure handling.
|
||
*
|
||
* @package PRAutoBlogger\Tests\Core
|
||
*/
|
||
|
||
namespace PRAutoBlogger\Tests\Core;
|
||
|
||
use PRAutoBlogger\Tests\BaseTestCase;
|
||
use Brain\Monkey\Functions;
|
||
|
||
class ImagePipelineTest extends BaseTestCase {
|
||
|
||
protected function setUp(): void {
|
||
parent::setUp();
|
||
|
||
// Mock WordPress functions used by the pipeline and its dependencies.
|
||
Functions\when( 'is_wp_error' )->alias( function ( $thing ) {
|
||
return $thing instanceof \WP_Error;
|
||
} );
|
||
Functions\when( 'wp_generate_uuid4' )->justReturn( 'test-uuid' );
|
||
Functions\when( 'get_option' )->alias( function ( $key, $default = false ) {
|
||
static $options = [
|
||
'prautoblogger_image_enabled' => '1',
|
||
'prautoblogger_image_style_suffix' => 'Style: test style',
|
||
];
|
||
return $options[ $key ] ?? $default;
|
||
} );
|
||
Functions\when( 'sanitize_text_field' )->returnArg();
|
||
Functions\when( 'wp_strip_all_tags' )->alias( function ( $str ) {
|
||
return trim( strip_tags( $str ) );
|
||
} );
|
||
Functions\when( 'update_post_meta' )->justReturn( true );
|
||
Functions\when( 'set_post_thumbnail' )->justReturn( true );
|
||
Functions\when( 'get_post_meta' )->justReturn( '' );
|
||
Functions\when( 'get_post' )->justReturn( (object) [ 'ID' => 1, 'post_content' => '<p>Test content</p>' ] );
|
||
Functions\when( 'wp_update_post' )->justReturn( 1 );
|
||
Functions\when( 'wp_get_attachment_url' )->justReturn( 'https://example.com/img.png' );
|
||
Functions\when( 'sanitize_title' )->returnArg();
|
||
Functions\when( 'esc_html__' )->returnArg();
|
||
Functions\when( 'esc_url' )->returnArg();
|
||
Functions\when( 'esc_attr' )->returnArg();
|
||
Functions\when( 'esc_html' )->returnArg();
|
||
}
|
||
|
||
/**
|
||
* Test generate_and_attach_images() returns early if disabled.
|
||
*/
|
||
public function test_generate_and_attach_images_skipped_if_disabled(): void {
|
||
Functions\when( 'get_option' )->alias( function ( $key, $default = false ) {
|
||
static $options = [ 'prautoblogger_image_enabled' => '0' ];
|
||
return $options[ $key ] ?? $default;
|
||
} );
|
||
|
||
$provider = $this->createMock( \PRAutoBlogger_Image_Provider_Interface::class );
|
||
$provider->expects( $this->never() )->method( 'generate_image' );
|
||
|
||
$cost_tracker = $this->createMock( \PRAutoBlogger_Cost_Tracker::class );
|
||
|
||
$pipeline = new \PRAutoBlogger_Image_Pipeline( $provider, $cost_tracker );
|
||
$result = $pipeline->generate_and_attach_images( 1, [ 'post_title' => 'Test' ] );
|
||
|
||
$this->assertArrayHasKey( 'cost_usd', $result );
|
||
$this->assertArrayHasKey( 'errors', $result );
|
||
$this->assertEmpty( $result['errors'] );
|
||
}
|
||
|
||
/**
|
||
* Test generate_and_attach_images() returns cost and error array structure.
|
||
*
|
||
* Pipeline now calls generate_image_batch() with keyed requests.
|
||
*/
|
||
public function test_generate_and_attach_images_returns_correct_structure(): void {
|
||
$image_result = [
|
||
'bytes' => 'fake_image_data',
|
||
'mime_type' => 'image/png',
|
||
'width' => 1200,
|
||
'height' => 630,
|
||
'model' => 'test-model',
|
||
'seed' => 123,
|
||
'cost_usd' => 0.05,
|
||
'latency_ms' => 2000,
|
||
];
|
||
|
||
$provider = $this->createMock( \PRAutoBlogger_Image_Provider_Interface::class );
|
||
$provider->method( 'estimate_cost' )->willReturn( 0.05 );
|
||
$provider->method( 'generate_image_batch' )->willReturn( [
|
||
'image_a' => $image_result,
|
||
] );
|
||
|
||
$cost_tracker = $this->createMock( \PRAutoBlogger_Cost_Tracker::class );
|
||
$cost_tracker->method( 'would_exceed_budget' )->willReturn( false );
|
||
|
||
$pipeline = new \PRAutoBlogger_Image_Pipeline( $provider, $cost_tracker );
|
||
|
||
Functions\when( 'get_temp_dir' )->justReturn( '/tmp/' );
|
||
Functions\when( 'media_handle_sideload' )->justReturn( 42 );
|
||
|
||
$result = $pipeline->generate_and_attach_images( 1, [ 'post_title' => 'Test' ] );
|
||
|
||
$this->assertArrayHasKey( 'cost_usd', $result );
|
||
$this->assertArrayHasKey( 'errors', $result );
|
||
$this->assertIsFloat( $result['cost_usd'] );
|
||
$this->assertIsArray( $result['errors'] );
|
||
}
|
||
|
||
/**
|
||
* Test that cost is accumulated when both images are generated via batch.
|
||
*/
|
||
public function test_cost_is_accumulated_for_both_images(): void {
|
||
$image_result = [
|
||
'bytes' => 'fake_image_data',
|
||
'mime_type' => 'image/png',
|
||
'width' => 1200,
|
||
'height' => 630,
|
||
'model' => 'test-model',
|
||
'cost_usd' => 0.05,
|
||
'latency_ms' => 2000,
|
||
];
|
||
|
||
$provider = $this->createMock( \PRAutoBlogger_Image_Provider_Interface::class );
|
||
$provider->method( 'estimate_cost' )->willReturn( 0.05 );
|
||
$provider->method( 'generate_image_batch' )->willReturn( [
|
||
'image_a' => $image_result,
|
||
'image_b' => $image_result,
|
||
] );
|
||
|
||
$cost_tracker = $this->createMock( \PRAutoBlogger_Cost_Tracker::class );
|
||
$cost_tracker->method( 'would_exceed_budget' )->willReturn( false );
|
||
$cost_tracker->expects( $this->exactly( 2 ) )->method( 'log_image_generation' );
|
||
|
||
$pipeline = new \PRAutoBlogger_Image_Pipeline( $provider, $cost_tracker );
|
||
|
||
Functions\when( 'get_temp_dir' )->justReturn( '/tmp/' );
|
||
Functions\when( 'media_handle_sideload' )->justReturn( 42 );
|
||
|
||
$result = $pipeline->generate_and_attach_images(
|
||
1,
|
||
[ 'post_title' => 'Test' ],
|
||
[ 'title' => 'Source' ]
|
||
);
|
||
|
||
// Cost should be accumulated from both images ($0.05 × 2 = $0.10).
|
||
$this->assertEqualsWithDelta( 0.10, $result['cost_usd'], 0.001 );
|
||
}
|
||
|
||
/**
|
||
* Test that Image B is NOT included in the batch when source_data is null.
|
||
*
|
||
* Regression test: the pipeline must only send 'image_a' in the batch
|
||
* request when no source data is provided.
|
||
*/
|
||
public function test_image_b_skipped_when_source_data_is_null(): void {
|
||
$image_result = [
|
||
'bytes' => 'fake_image_data',
|
||
'mime_type' => 'image/png',
|
||
'width' => 1200,
|
||
'height' => 630,
|
||
'model' => 'test-model',
|
||
'cost_usd' => 0.05,
|
||
'latency_ms' => 2000,
|
||
];
|
||
|
||
$provider = $this->createMock( \PRAutoBlogger_Image_Provider_Interface::class );
|
||
$provider->method( 'estimate_cost' )->willReturn( 0.05 );
|
||
// Verify batch only contains 'image_a'.
|
||
$provider->expects( $this->once() )
|
||
->method( 'generate_image_batch' )
|
||
->with( $this->callback( function ( $requests ) {
|
||
return array_key_exists( 'image_a', $requests )
|
||
&& ! array_key_exists( 'image_b', $requests );
|
||
} ) )
|
||
->willReturn( [ 'image_a' => $image_result ] );
|
||
|
||
$cost_tracker = $this->createMock( \PRAutoBlogger_Cost_Tracker::class );
|
||
$cost_tracker->method( 'would_exceed_budget' )->willReturn( false );
|
||
$cost_tracker->expects( $this->exactly( 1 ) )->method( 'log_image_generation' );
|
||
|
||
$pipeline = new \PRAutoBlogger_Image_Pipeline( $provider, $cost_tracker );
|
||
|
||
Functions\when( 'get_temp_dir' )->justReturn( '/tmp/' );
|
||
Functions\when( 'media_handle_sideload' )->justReturn( 42 );
|
||
|
||
$result = $pipeline->generate_and_attach_images( 1, [ 'post_title' => 'Test' ], null );
|
||
|
||
$this->assertArrayHasKey( 'image_a_id', $result );
|
||
$this->assertArrayNotHasKey( 'image_b_id', $result );
|
||
}
|
||
|
||
/**
|
||
* Test graceful handling when batch generation throws.
|
||
*/
|
||
public function test_graceful_failure_when_batch_generation_throws(): void {
|
||
$provider = $this->createMock( \PRAutoBlogger_Image_Provider_Interface::class );
|
||
$provider->method( 'estimate_cost' )->willReturn( 0.05 );
|
||
$provider->method( 'generate_image_batch' )->willThrowException( new \Exception( 'API timeout' ) );
|
||
|
||
$cost_tracker = $this->createMock( \PRAutoBlogger_Cost_Tracker::class );
|
||
$cost_tracker->method( 'would_exceed_budget' )->willReturn( false );
|
||
|
||
$pipeline = new \PRAutoBlogger_Image_Pipeline( $provider, $cost_tracker );
|
||
|
||
$result = $pipeline->generate_and_attach_images( 1, [ 'post_title' => 'Test' ] );
|
||
|
||
$this->assertIsArray( $result );
|
||
$this->assertNotEmpty( $result['errors'] );
|
||
$this->assertStringContainsString( 'API timeout', implode( ' ', $result['errors'] ) );
|
||
}
|
||
|
||
/**
|
||
* Test that a Logger::warning row is persisted when image_data carries an error.
|
||
*
|
||
* Covers Issue 2 from the image-mime-bug thread: previously the pipeline
|
||
* pushed the error into $result['errors'] silently, with no WARNING-level
|
||
* event_log row visible to ops. This regression-guards that a WARNING row
|
||
* now fires whether or not the outer catch in the caller triggers.
|
||
*/
|
||
public function test_partial_batch_failure_emits_warning_log_row(): void {
|
||
// Seed Logger's log_level so warnings actually get written.
|
||
Functions\when( 'get_option' )->alias( function ( $key, $default = false ) {
|
||
static $options = [
|
||
'prautoblogger_image_enabled' => '1',
|
||
'prautoblogger_log_level' => 'info',
|
||
];
|
||
return $options[ $key ] ?? $default;
|
||
} );
|
||
|
||
$mock_wpdb = $this->create_mock_wpdb();
|
||
$captured_rows = [];
|
||
$mock_wpdb->method( 'insert' )->willReturnCallback(
|
||
function ( $table, $row ) use ( &$captured_rows ) {
|
||
$captured_rows[] = $row;
|
||
return 1;
|
||
}
|
||
);
|
||
$GLOBALS['wpdb'] = $mock_wpdb;
|
||
|
||
$provider = $this->createMock( \PRAutoBlogger_Image_Provider_Interface::class );
|
||
$provider->method( 'estimate_cost' )->willReturn( 0.05 );
|
||
$provider->method( 'generate_image_batch' )->willReturn( [
|
||
'image_a' => [ 'error' => 'HTTP 400: flux-1-schnell is not a valid model ID' ],
|
||
] );
|
||
|
||
$cost_tracker = $this->createMock( \PRAutoBlogger_Cost_Tracker::class );
|
||
$cost_tracker->method( 'would_exceed_budget' )->willReturn( false );
|
||
|
||
$pipeline = new \PRAutoBlogger_Image_Pipeline( $provider, $cost_tracker );
|
||
$pipeline->generate_and_attach_images( 1, [ 'post_title' => 'Test' ], null );
|
||
|
||
$warning_rows = array_filter(
|
||
$captured_rows,
|
||
static fn( $row ) => ( $row['level'] ?? '' ) === 'warning'
|
||
&& ( $row['context'] ?? '' ) === 'image_pipeline'
|
||
);
|
||
$this->assertNotEmpty(
|
||
$warning_rows,
|
||
'Expected at least one image_pipeline WARNING row when image_data has an error key.'
|
||
);
|
||
|
||
unset( $GLOBALS['wpdb'] );
|
||
}
|
||
|
||
/**
|
||
* NSFW-blocked slots should be retried once with a sanitized fallback
|
||
* prompt. Retry success replaces the error entry with a real image.
|
||
*/
|
||
public function test_nsfw_blocked_slot_is_retried_with_fallback_prompt(): void {
|
||
// NSFW retry is default on; explicit for clarity.
|
||
Functions\when( 'get_option' )->alias( function ( $key, $default = false ) {
|
||
static $options = [
|
||
'prautoblogger_image_enabled' => '1',
|
||
'prautoblogger_image_nsfw_retry' => '1',
|
||
'prautoblogger_image_style_suffix' => 'Style: test suffix',
|
||
'prautoblogger_log_level' => 'info',
|
||
];
|
||
return $options[ $key ] ?? $default;
|
||
} );
|
||
|
||
$success_result = [
|
||
'bytes' => 'fake_image_bytes',
|
||
'mime_type' => 'image/png',
|
||
'width' => 1200,
|
||
'height' => 632,
|
||
'model' => 'flux-1-schnell',
|
||
'cost_usd' => 0.000834,
|
||
'latency_ms' => 1500,
|
||
];
|
||
|
||
$provider = $this->createMock( \PRAutoBlogger_Image_Provider_Interface::class );
|
||
$provider->method( 'estimate_cost' )->willReturn( 0.001 );
|
||
// First batch: NSFW. Second batch (retry for image_a): success.
|
||
$provider->expects( $this->exactly( 2 ) )
|
||
->method( 'generate_image_batch' )
|
||
->willReturnOnConsecutiveCalls(
|
||
[ 'image_a' => [ 'error' => 'NSFW', 'error_type' => 'nsfw_blocked' ] ],
|
||
[ 'image_a' => $success_result ]
|
||
);
|
||
|
||
$cost_tracker = $this->createMock( \PRAutoBlogger_Cost_Tracker::class );
|
||
$cost_tracker->method( 'would_exceed_budget' )->willReturn( false );
|
||
|
||
Functions\when( 'get_temp_dir' )->justReturn( '/tmp/' );
|
||
Functions\when( 'media_handle_sideload' )->justReturn( 42 );
|
||
|
||
$pipeline = new \PRAutoBlogger_Image_Pipeline( $provider, $cost_tracker );
|
||
$result = $pipeline->generate_and_attach_images( 1, [ 'post_title' => 'Test Article' ] );
|
||
|
||
// Retry succeeded — image_a_id set, no errors.
|
||
$this->assertArrayHasKey( 'image_a_id', $result );
|
||
$this->assertEmpty( $result['errors'] );
|
||
}
|
||
|
||
/**
|
||
* When `prautoblogger_image_nsfw_retry` is off, blocked slots stay
|
||
* blocked — no second HTTP call, pipeline publishes without that
|
||
* image. Failsafe for when the filter gets trigger-happy.
|
||
*/
|
||
public function test_nsfw_retry_skipped_when_setting_disabled(): void {
|
||
Functions\when( 'get_option' )->alias( function ( $key, $default = false ) {
|
||
static $options = [
|
||
'prautoblogger_image_enabled' => '1',
|
||
'prautoblogger_image_nsfw_retry' => '0',
|
||
];
|
||
return $options[ $key ] ?? $default;
|
||
} );
|
||
|
||
$provider = $this->createMock( \PRAutoBlogger_Image_Provider_Interface::class );
|
||
$provider->method( 'estimate_cost' )->willReturn( 0.001 );
|
||
$provider->expects( $this->exactly( 1 ) )
|
||
->method( 'generate_image_batch' )
|
||
->willReturn( [
|
||
'image_a' => [ 'error' => 'NSFW', 'error_type' => 'nsfw_blocked' ],
|
||
] );
|
||
|
||
$cost_tracker = $this->createMock( \PRAutoBlogger_Cost_Tracker::class );
|
||
$cost_tracker->method( 'would_exceed_budget' )->willReturn( false );
|
||
|
||
$pipeline = new \PRAutoBlogger_Image_Pipeline( $provider, $cost_tracker );
|
||
$result = $pipeline->generate_and_attach_images( 1, [ 'post_title' => 'Test Article' ] );
|
||
|
||
$this->assertArrayNotHasKey( 'image_a_id', $result );
|
||
$this->assertNotEmpty( $result['errors'] );
|
||
}
|
||
|
||
/**
|
||
* Test graceful handling when one image in the batch returns an error.
|
||
*/
|
||
public function test_partial_batch_failure_handled_gracefully(): void {
|
||
$provider = $this->createMock( \PRAutoBlogger_Image_Provider_Interface::class );
|
||
$provider->method( 'estimate_cost' )->willReturn( 0.05 );
|
||
$provider->method( 'generate_image_batch' )->willReturn( [
|
||
'image_a' => [
|
||
'bytes' => 'fake_image_data',
|
||
'mime_type' => 'image/png',
|
||
'width' => 1200,
|
||
'height' => 630,
|
||
'model' => 'test-model',
|
||
'cost_usd' => 0.05,
|
||
'latency_ms' => 2000,
|
||
],
|
||
'image_b' => [ 'error' => 'HTTP 429: rate limited' ],
|
||
] );
|
||
|
||
$cost_tracker = $this->createMock( \PRAutoBlogger_Cost_Tracker::class );
|
||
$cost_tracker->method( 'would_exceed_budget' )->willReturn( false );
|
||
// Only Image A gets logged — Image B failed.
|
||
$cost_tracker->expects( $this->exactly( 1 ) )->method( 'log_image_generation' );
|
||
|
||
$pipeline = new \PRAutoBlogger_Image_Pipeline( $provider, $cost_tracker );
|
||
|
||
Functions\when( 'get_temp_dir' )->justReturn( '/tmp/' );
|
||
Functions\when( 'media_handle_sideload' )->justReturn( 42 );
|
||
|
||
$result = $pipeline->generate_and_attach_images(
|
||
1,
|
||
[ 'post_title' => 'Test' ],
|
||
[ 'title' => 'Source' ]
|
||
);
|
||
|
||
// Image A succeeds, Image B records an error.
|
||
$this->assertArrayHasKey( 'image_a_id', $result );
|
||
$this->assertArrayNotHasKey( 'image_b_id', $result );
|
||
$this->assertNotEmpty( $result['errors'] );
|
||
$this->assertStringContainsString( '429', implode( ' ', $result['errors'] ) );
|
||
}
|
||
}
|